Remove icomplete workaround

Remove icomplete workaround

[Aaron Jensen]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024

The reason this fixed things was not captured and I can not reproduce
the bug with the fix disabled on master.

This workaround has been copied to other libraries without clear
understanding of why it existed in the first place and it caused a
problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581

Would it be possible to remove it? I'm ccing the original reporter and
fixer in case they are able to shed more light on this or test without
the fix to see if they can reproduce it.

I've attached a patch if we are good to remove it.

Thanks,

Aaron

[-- Attachment #2: 0001-lisp-icomplete.el-icomplete-exhibit-Remove-workaroun.patch --]
[-- Type: application/octet-stream, Size: 1113 bytes --]

From 977e40556e9b416e87d9da90b8b5a44068dea378 Mon Sep 17 00:00:00 2001
From: Aaron Jensen <aaronjensen@gmail.com>
Date: Sun, 31 Oct 2021 20:40:43 -0400
Subject: [PATCH] * lisp/icomplete.el (icomplete-exhibit): Remove workaround

---
 lisp/icomplete.el | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index 01033474d3..a61c9d6354 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -716,11 +716,6 @@ icomplete-exhibit
             (delete-region (overlay-start rfn-eshadow-overlay)
                            (overlay-end rfn-eshadow-overlay)))
           (let* ((field-string (icomplete--field-string))
-                 ;; Not sure why, but such requests seem to come
-                 ;; every once in a while.  It's not fully
-                 ;; deterministic but `C-x C-f M-DEL M-DEL ...'
-                 ;; seems to trigger it fairly often!
-                 (while-no-input-ignore-events '(selection-request))
                  (text (while-no-input
                          (icomplete-completions
                           field-string
-- 
2.33.1

Re: Remove icomplete workaround

[Stefan Kangas]

Aaron Jensen <aaronjensen@gmail.com> writes:

> Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024

Thanks for the bug report and patch.

If you don't see any follow-ups within the next week or so, please
forward it to bug-gnu-emacs@gnu.org so that we don't lose track of this
issue.  Thanks!

(I can't comment further as I don't know anything about icomplete.el.)