unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* master 5308a4e11e: Improve image-tests.el Commentary
@ 2022-09-07 11:24 Eli Zaretskii
  2022-09-08  0:45 ` Stefan Kangas
  0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2022-09-07 11:24 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

> --- a/test/src/image-tests.el
> +++ b/test/src/image-tests.el
> @@ -22,8 +22,11 @@
>  ;;; Commentary:
>  
>  ;; Most of these tests will only run in a GUI session, and not with
> -;; "make check".  Run them manually in an interactive session with
> -;; `M-x eval-buffer' followed by `M-x ert'.
> +;; "make check".  You must run them manually in an interactive session
> +;; with, for example, `M-x eval-buffer' followed by `M-x ert'.
> +;;
> +;; To run these tests from the command line, try:
> +;;     ./src/emacs -Q -l test/src/image-tests.el -eval "(ert t)"

IMO, the above means that these tests should be moved out of test/src,
and into test/manual/.  That's where we put all the tests that must be
run manually.

Thanks.



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master 5308a4e11e: Improve image-tests.el Commentary
  2022-09-07 11:24 master 5308a4e11e: Improve image-tests.el Commentary Eli Zaretskii
@ 2022-09-08  0:45 ` Stefan Kangas
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2022-09-08  0:45 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>> +;; To run these tests from the command line, try:
>> +;;     ./src/emacs -Q -l test/src/image-tests.el -eval "(ert t)"
>
> IMO, the above means that these tests should be moved out of test/src,
> and into test/manual/.  That's where we put all the tests that must be
> run manually.

Thanks, I've now moved these tests (commit 5b87429d99).



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-08  0:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 11:24 master 5308a4e11e: Improve image-tests.el Commentary Eli Zaretskii
2022-09-08  0:45 ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).