* Re: master ffbea0d: Tweak two time.el tests
[not found] ` <20201021152241.4FFC8209D4@vcs0.savannah.gnu.org>
@ 2020-10-21 16:11 ` Stefan Monnier
2020-10-21 16:40 ` Stefan Kangas
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2020-10-21 16:11 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
> * test/lisp/time-tests.el (time-tests-display-time-update--load)
> (time-tests-display-time-update): Tweak tests.
Context already makes it clear that `time-tests-display-time-update` and
`time-tests-display-time-update--load` are tests, and that you're making
some change in them. So "Tweak tests" doesn't say much, really.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master ffbea0d: Tweak two time.el tests
2020-10-21 16:11 ` master ffbea0d: Tweak two time.el tests Stefan Monnier
@ 2020-10-21 16:40 ` Stefan Kangas
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2020-10-21 16:40 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * test/lisp/time-tests.el (time-tests-display-time-update--load)
>> (time-tests-display-time-update): Tweak tests.
>
> Context already makes it clear that `time-tests-display-time-update` and
> `time-tests-display-time-update--load` are tests, and that you're making
> some change in them. So "Tweak tests" doesn't say much, really.
Yes, I realized that as well (after pushing). I should probably have
said "Tweak tests to be more strict" or something along those lines.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-21 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201021152239.25885.23627@vcs0.savannah.gnu.org>
[not found] ` <20201021152241.4FFC8209D4@vcs0.savannah.gnu.org>
2020-10-21 16:11 ` master ffbea0d: Tweak two time.el tests Stefan Monnier
2020-10-21 16:40 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).