Re: master d65534d254: * lisp/emacs-list/eieio-compat.el: Really move to obsolete

Re: master d65534d254: * lisp/emacs-list/eieio-compat.el: Really move to obsolete

[Lars Ingebrigtsen]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

>     * lisp/emacs-list/eieio-compat.el: Really move to obsolete

I don't know whether it's this change or not, but:

2 files did not contain any tests:
  lisp/emacs-lisp/eieio-tests/eieio-tests.log
  lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.log

and

Debugger entered--Lisp error: (void-function defmethod)
  (defmethod eitest-F :BEFORE ((_p eitest-B-base1)) (eieio-test-method-store :BEFORE 'eitest-B-base1))
  eval-buffer(#<buffer  *load*> nil "/home/larsi/src/emacs/trunk/test/lisp/emacs-lisp/e..." nil t)  ; Reading at buffer position 4463
  load-with-code-conversion("/home/larsi/src/emacs/trunk/test/lisp/emacs-lisp/e..." "/home/larsi/src/emacs/trunk/test/lisp/emacs-lisp/e..." nil t)



-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master d65534d254: * lisp/emacs-list/eieio-compat.el: Really move to obsolete

[Stefan Kangas]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

> branch: master
> commit d65534d254b3965ea82a9300c12c5c07f88818b7
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/emacs-list/eieio-compat.el: Really move to obsolete

After this or some other recent and related commit, we get these
warnings:

  In toplevel form:
  lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:58:1:
Warning: Package eieio-compat is deprecated
    GEN      lisp/emacs-lisp/ert-x-tests.log

  In toplevel form:
  lisp/emacs-lisp/eieio-tests/eieio-tests.el:30:1: Warning: Package
eieio-compat is deprecated

I'm not sure about the best way to fix them.  Could we just move those
parts that require eieio-compat.el to a new file eieio-compat-tests.el?