unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Dmitry Gutov <dgutov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: master 12ca463 1/4: ; * test/lisp/textmodes/css-mode-tests.el: Add TODO.
Date: Wed, 23 Sep 2020 14:06:27 +0000	[thread overview]
Message-ID: <CADwFkm=rYpbsGeARcv3T9+B5YFzQQXv3owXithAEeSuZPT69gw@mail.gmail.com> (raw)
In-Reply-To: <62c23861-62e0-2aab-7feb-70c03ea58fdf@yandex.ru>

Dmitry Gutov <dgutov@yandex.ru> writes:

>> That said, please feel free to revert any commits you disagree with or
>> that gets in the way of your work.  I think it goes without saying that
>> I don't want to make debugging harder for you or anyone else.
>
> I guess unless I do the above, I don't have a moral standing to revert them?

Whatever you do, I think you have about the same moral standing as I had
to make the changes in the first place.  :-)

But maybe we can find a way to make everyone happy (see below).

> Having an ERT test per each file in there might seem a tad redundant
> given the above option, but maybe there are good reasons why nobody has
> fixed the situations yet. As long as said manual test files are present,
> in one form or another, the debugging workflows can be retained.

OK, that is encouraging.  Would arranging things more or less as in
commit b63c3535b0 be satisfactory then, or am I misunderstanding what
you mean?

>> But if there are limitations in debugging with ert, perhaps we should
>> work on improving its capabilities?
>
> It's capable enough in that regard (e.g. one can press 'd' and drop into
> the debugger, in the target buffer, exactly at the point of failure),
> yet still it requires more ceremony than the "manual" approach.

I agree that ERT's interactive UI could be more streamlined (that's why
I prefer running tests in batch).  Maybe we could think about ways to
remove some of the ceremony you are speaking of?



      reply	other threads:[~2020-09-23 14:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200921144653.9320.23809@vcs0.savannah.gnu.org>
     [not found] ` <20200921144656.3E99C206ED@vcs0.savannah.gnu.org>
2020-09-21 17:54   ` master 12ca463 1/4: ; * test/lisp/textmodes/css-mode-tests.el: Add TODO Dmitry Gutov
2020-09-21 18:23     ` Stefan Kangas
2020-09-22 13:33       ` Lars Ingebrigtsen
2020-09-22 13:54         ` Stefan Kangas
2020-09-22 15:06           ` Lars Ingebrigtsen
2020-09-22 18:34             ` Dmitry Gutov
2020-09-22 16:22         ` Stefan Monnier
2020-09-23 13:56           ` Stefan Kangas
2020-09-23 14:28             ` Stefan Monnier
2020-09-23 15:44               ` Stefan Kangas
2020-09-22 19:32       ` Dmitry Gutov
2020-09-23 14:06         ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=rYpbsGeARcv3T9+B5YFzQQXv3owXithAEeSuZPT69gw@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).