From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 12ca463 1/4: ; * test/lisp/textmodes/css-mode-tests.el: Add TODO. Date: Wed, 23 Sep 2020 14:06:27 +0000 Message-ID: References: <20200921144653.9320.23809@vcs0.savannah.gnu.org> <20200921144656.3E99C206ED@vcs0.savannah.gnu.org> <62c23861-62e0-2aab-7feb-70c03ea58fdf@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8503"; mail-complaints-to="usenet@ciao.gmane.io" To: Dmitry Gutov , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 23 16:07:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kL5QG-00027x-Ai for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Sep 2020 16:07:04 +0200 Original-Received: from localhost ([::1]:34002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL5QF-00009P-Ax for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Sep 2020 10:07:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL5Pk-000894-Or for emacs-devel@gnu.org; Wed, 23 Sep 2020 10:06:32 -0400 Original-Received: from mail-ed1-f52.google.com ([209.85.208.52]:36531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kL5Pi-0001Ww-3l for emacs-devel@gnu.org; Wed, 23 Sep 2020 10:06:32 -0400 Original-Received: by mail-ed1-f52.google.com with SMTP id w1so20040165edr.3 for ; Wed, 23 Sep 2020 07:06:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=x6loLBG9guNK/UJv5ygsdpbER6TeU2WfPUjqQ5dpjbM=; b=R/azuhu0J7eF2rY9OSWvjRxM1p0+JxSB40YkdvEcmrO0T3x1KRrc/QrtYkepH3/Byc LzpqMt6ERy82tStsgv399NO8eyQNPIBUM2dFI+apllDCcwvrw1vrJ3V06y3nw2mbh2cw 5lnsfL+n/hTZHdFQWwoFXXgAL5tDC8ZWUG5nYyVIWtI7cDzEAoL7TxTGQkwFrOhfvIz2 tr/Pld5fVg5Kdxq7B74xxa2+NCdILphjU3nE/T7M03AAVfGPDPU9oky5bpJbMyQueq3L F4ZPJtvHFQdXYrd4C2Db0okjyXhwgUyW19woEH5NRYa6nUKaxO6gkAU+uOrv9Q5m2Oyf BIhA== X-Gm-Message-State: AOAM532T0dK/ESIRGSEEeazb7+ReggZND2sa0tAcsxrhVOD2et1Rpb4C mZECFa+mvlIpW86robCF5ny9QLb0t9ay8VGPEis= X-Google-Smtp-Source: ABdhPJyMPtdWOGO2z6jS70AKubA+8LcC0HNmR9GOZwMEY39CdcopiH0khkin7ApOsh6p6KK04iwaiI3RvfTxs7G2zt4= X-Received: by 2002:a50:ce06:: with SMTP id y6mr10027728edi.273.1600869988704; Wed, 23 Sep 2020 07:06:28 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 23 Sep 2020 14:06:27 +0000 In-Reply-To: <62c23861-62e0-2aab-7feb-70c03ea58fdf@yandex.ru> Received-SPF: pass client-ip=209.85.208.52; envelope-from=stefankangas@gmail.com; helo=mail-ed1-f52.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/23 09:45:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256363 Archived-At: Dmitry Gutov writes: >> That said, please feel free to revert any commits you disagree with or >> that gets in the way of your work. I think it goes without saying that >> I don't want to make debugging harder for you or anyone else. > > I guess unless I do the above, I don't have a moral standing to revert them? Whatever you do, I think you have about the same moral standing as I had to make the changes in the first place. :-) But maybe we can find a way to make everyone happy (see below). > Having an ERT test per each file in there might seem a tad redundant > given the above option, but maybe there are good reasons why nobody has > fixed the situations yet. As long as said manual test files are present, > in one form or another, the debugging workflows can be retained. OK, that is encouraging. Would arranging things more or less as in commit b63c3535b0 be satisfactory then, or am I misunderstanding what you mean? >> But if there are limitations in debugging with ert, perhaps we should >> work on improving its capabilities? > > It's capable enough in that regard (e.g. one can press 'd' and drop into > the debugger, in the target buffer, exactly at the point of failure), > yet still it requires more ceremony than the "manual" approach. I agree that ERT's interactive UI could be more streamlined (that's why I prefer running tests in batch). Maybe we could think about ways to remove some of the ceremony you are speaking of?