Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d probably needs to be reverted

Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d probably needs to be reverted

[Philipp Stephani]

Hi,

Flymake is in Elpa and is supposed to be compatible with Emacs 26.1.
Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d introduces an
incompatibility and should probably be reverted.

Thanks,
Philipp

Re: Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d probably needs to be reverted

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

On 3/14/19 5:49 AM, Philipp Stephani wrote:
> Flymake is in Elpa and is supposed to be compatible with Emacs 26.1.
> Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d introduces an
> incompatibility and should probably be reverted.
>
> Thanks,

Sure, I installed the attached.


[-- Attachment #2: 0001-Bring-back-Emacs-26-compatibility-to-flymake.el.patch --]
[-- Type: text/x-patch, Size: 1037 bytes --]

From fe97ca111d153a67c83058e6b742d7ca704e6189 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 15 Mar 2019 18:31:31 -0700
Subject: [PATCH] Bring back Emacs 26 compatibility to flymake.el

* lisp/progmodes/flymake.el (flymake--schedule-timer-maybe):
Revert to using seconds-to-time, since this file is part
of ELPA and needs to work on Emacs 26 too.
---
 lisp/progmodes/flymake.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 7afcf7891d..830d700963 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1005,7 +1005,9 @@ flymake--schedule-timer-maybe
     (setq
      flymake-timer
      (run-with-idle-timer
-      (encode-time flymake-no-changes-timeout)
+      ;; This can use encode-time instead of seconds-to-time,
+      ;; once we can assume Emacs 27 or later.
+      (seconds-to-time flymake-no-changes-timeout)
       nil
       (lambda (buffer)
         (when (buffer-live-p buffer)
-- 
2.20.1

Re: Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d probably needs to be reverted

[Philipp Stephani]

Am Sa., 16. März 2019 um 02:32 Uhr schrieb Paul Eggert <eggert@cs.ucla.edu>:
>
> On 3/14/19 5:49 AM, Philipp Stephani wrote:
> > Flymake is in Elpa and is supposed to be compatible with Emacs 26.1.
> > Commit 57c74793c46c6533b63836f00aecaf3ac2accb6d introduces an
> > incompatibility and should probably be reverted.
> >
> > Thanks,
>
> Sure, I installed the attached.
>

Thanks!