* Why do we have xsignal?
@ 2019-04-22 17:30 Philipp Stephani
2019-04-22 17:38 ` Eli Zaretskii
2019-04-22 19:02 ` Paul Eggert
0 siblings, 2 replies; 5+ messages in thread
From: Philipp Stephani @ 2019-04-22 17:30 UTC (permalink / raw)
To: Emacs developers
Hi,
xsignal is exactly the same as Fsignal, is there any reason we need to keep it?
Thanks,
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Why do we have xsignal?
2019-04-22 17:30 Why do we have xsignal? Philipp Stephani
@ 2019-04-22 17:38 ` Eli Zaretskii
2019-04-22 18:26 ` Philipp Stephani
2019-04-22 19:02 ` Paul Eggert
1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2019-04-22 17:38 UTC (permalink / raw)
To: Philipp Stephani; +Cc: emacs-devel
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 22 Apr 2019 19:30:33 +0200
>
> xsignal is exactly the same as Fsignal, is there any reason we need to keep it?
To mark it as _Noreturn, I guess.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Why do we have xsignal?
2019-04-22 17:38 ` Eli Zaretskii
@ 2019-04-22 18:26 ` Philipp Stephani
2019-04-22 18:35 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Philipp Stephani @ 2019-04-22 18:26 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Emacs developers
Am Mo., 22. Apr. 2019 um 19:38 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Mon, 22 Apr 2019 19:30:33 +0200
> >
> > xsignal is exactly the same as Fsignal, is there any reason we need to keep it?
>
> To mark it as _Noreturn, I guess.
But Fsignal is also marked as _Noreturn in globals.h.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Why do we have xsignal?
2019-04-22 18:26 ` Philipp Stephani
@ 2019-04-22 18:35 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2019-04-22 18:35 UTC (permalink / raw)
To: Philipp Stephani; +Cc: emacs-devel
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 22 Apr 2019 20:26:45 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>
>
> > > xsignal is exactly the same as Fsignal, is there any reason we need to keep it?
> >
> > To mark it as _Noreturn, I guess.
>
> But Fsignal is also marked as _Noreturn in globals.h.
Right, that was a recent change. Then I don't know.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Why do we have xsignal?
2019-04-22 17:30 Why do we have xsignal? Philipp Stephani
2019-04-22 17:38 ` Eli Zaretskii
@ 2019-04-22 19:02 ` Paul Eggert
1 sibling, 0 replies; 5+ messages in thread
From: Paul Eggert @ 2019-04-22 19:02 UTC (permalink / raw)
To: Philipp Stephani; +Cc: Emacs developers
On 4/22/19 10:30 AM, Philipp Stephani wrote:
> xsignal is exactly the same as Fsignal, is there any reason we need to keep it?
The two names are present only for historical reasons; see Bug#24047. I
don't see any reason to keep xsignal other than inertia, and would favor
dropping xsignal and changing its callers to use Fsignal as this will
simplify the code.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-22 19:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-22 17:30 Why do we have xsignal? Philipp Stephani
2019-04-22 17:38 ` Eli Zaretskii
2019-04-22 18:26 ` Philipp Stephani
2019-04-22 18:35 ` Eli Zaretskii
2019-04-22 19:02 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).