* Re: [elpa] externals/ess 2b13c10ebf 2/2: Delete new-line check with arbitrary prompts
[not found] ` <20221108155748.19961C00AB5@vcs2.savannah.gnu.org>
@ 2022-11-08 17:07 ` Stefan Monnier
2022-11-08 17:16 ` Lionel Henry
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2022-11-08 17:07 UTC (permalink / raw)
To: emacs-devel; +Cc: Lionel Henry
> - (string-match-p (concat "^" inferior-ess-primary-prompt "\\'") string))
> + (string-match-p (concat ".*" inferior-ess-primary-prompt "\\'") string))
".*" at the beginning of a `string-match(-p)` is useless and just makes
the match slower.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [elpa] externals/ess 2b13c10ebf 2/2: Delete new-line check with arbitrary prompts
2022-11-08 17:07 ` [elpa] externals/ess 2b13c10ebf 2/2: Delete new-line check with arbitrary prompts Stefan Monnier
@ 2022-11-08 17:16 ` Lionel Henry
0 siblings, 0 replies; 2+ messages in thread
From: Lionel Henry @ 2022-11-08 17:16 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Thanks, now fixed.
On 11/8/22, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> - (string-match-p (concat "^" inferior-ess-primary-prompt
>> "\\'") string))
>> + (string-match-p (concat ".*" inferior-ess-primary-prompt
>> "\\'") string))
>
> ".*" at the beginning of a `string-match(-p)` is useless and just makes
> the match slower.
>
>
> Stefan
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-08 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166792306755.2916.1471997945316928242@vcs2.savannah.gnu.org>
[not found] ` <20221108155748.19961C00AB5@vcs2.savannah.gnu.org>
2022-11-08 17:07 ` [elpa] externals/ess 2b13c10ebf 2/2: Delete new-line check with arbitrary prompts Stefan Monnier
2022-11-08 17:16 ` Lionel Henry
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).