From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: add-hook and defvar
Date: Thu, 5 Mar 2015 18:45:23 -0300 [thread overview]
Message-ID: <CAAdUY-KpgzMjiOovu=q8OkjNUNUY6qY_E1JVxT7W6XkbjvBOyg@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkScF5OsriXerGivyWfm7WpTsZt23fXbm3gksHgN7CZvvQ@mail.gmail.com>
This should probably do the same if the variable name ends with
"-functions" (since IIUC that's the correct way of naming a hook where
the functions should take arguments).
2015-03-05 17:28 GMT-03:00 Philipp Stephani <p.stephani2@gmail.com>:
>
>
> Stefan Monnier <monnier@iro.umontreal.ca> schrieb am Mi., 25. Feb. 2015 um
> 03:56 Uhr:
>
>> > Is this something the byte compiler could warn about? At least normal
>> > hooks
>> > by convention end in "-hook", so a warning could be emitted every time
>> > such
>> > a variable is defined that doesn't have nil as default.
>>
>> Yes, we could do that. Patch welcome,
>>
>>
>
> Added a patch.
next prev parent reply other threads:[~2015-03-05 21:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 19:55 add-hook and defvar Artur Malabarba
2015-02-21 21:05 ` Drew Adams
2015-02-21 22:35 ` Robin Templeton
2015-02-23 5:00 ` Artur Malabarba
2015-02-22 19:18 ` Stefan Monnier
2015-02-23 5:10 ` Artur Malabarba
2015-02-23 22:31 ` Stefan Monnier
2015-02-24 6:29 ` Philipp Stephani
2015-02-25 2:56 ` Stefan Monnier
2015-03-05 20:28 ` Philipp Stephani
2015-03-05 21:45 ` Artur Malabarba [this message]
2015-03-06 19:05 ` Philipp Stephani
2015-03-06 20:27 ` Artur Malabarba
2015-03-10 2:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdUY-KpgzMjiOovu=q8OkjNUNUY6qY_E1JVxT7W6XkbjvBOyg@mail.gmail.com' \
--to=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).