unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: bruce.connor.am@gmail.com, emacs-devel <emacs-devel@gnu.org>
Subject: RE: add-hook and defvar
Date: Sat, 21 Feb 2015 13:05:36 -0800 (PST)	[thread overview]
Message-ID: <2fba39e3-171e-49f8-b49a-61349cd93256@default> (raw)
In-Reply-To: <CAAdUY-Kn_VOOASJGh8WN5cc8jY1kmXJ5GpG=JDzYDahbOkzmfg@mail.gmail.com>

> The big disadvantage is that it's not backwards compatible. Any code
> out there that relies on the variable being set by `add-hook' will
> break.

From that alone it does not sound like a good idea to me.  `add-hook'
has been around forever.  The amount of 3rd-party code that calls it
and expects the longstanding behavior must be non-neglible.

Just one opinion.



  reply	other threads:[~2015-02-21 21:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-21 19:55 add-hook and defvar Artur Malabarba
2015-02-21 21:05 ` Drew Adams [this message]
2015-02-21 22:35 ` Robin Templeton
2015-02-23  5:00   ` Artur Malabarba
2015-02-22 19:18 ` Stefan Monnier
2015-02-23  5:10   ` Artur Malabarba
2015-02-23 22:31     ` Stefan Monnier
2015-02-24  6:29       ` Philipp Stephani
2015-02-25  2:56         ` Stefan Monnier
2015-03-05 20:28           ` Philipp Stephani
2015-03-05 21:45             ` Artur Malabarba
2015-03-06 19:05               ` Philipp Stephani
2015-03-06 20:27                 ` Artur Malabarba
2015-03-10  2:14             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fba39e3-171e-49f8-b49a-61349cd93256@default \
    --to=drew.adams@oracle.com \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).