unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] scratch/package.el-async-refresh bc0fc5e: Implement async refreshing in package-refresh-contents
Date: Tue, 31 Mar 2015 11:02:29 +0100	[thread overview]
Message-ID: <CAAdUY-KD2Cg1hPdSeZD_JyKt_tA8exwtBCAyw04mmtigw7dkAg@mail.gmail.com> (raw)
In-Reply-To: <jwvego69c4r.fsf-monnier+emacsdiffs@gnu.org>

> I personally would only place a single function on it, tho (which then
> calls the above 3 functions).  Or I would keep it nil by default, and
> just put a call to that (new) function wherever you currently run
> package--post-download-archives-hook.

Yes, I've changed it to this last one. Makes more sense here.

>
>> +  (add-hook 'package--post-download-archives-hook
>> +            #'package-menu--populate-new-package-list 'append)
>> +  (add-hook 'package--post-download-archives-hook
>> +            #'package-menu--revert 'append)
>> +  (add-hook 'package--post-download-archives-hook
>> +            #'package-menu--find-and-notify-upgrades 'append)
>
> Similarly, here I'd put a single function on the hook which then calls
> those 3.

Done.



      reply	other threads:[~2015-03-31 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150331002109.4237.29402@vcs.savannah.gnu.org>
     [not found] ` <E1Ycjva-00017J-Il@vcs.savannah.gnu.org>
2015-03-31  1:46   ` [Emacs-diffs] scratch/package.el-async-refresh bc0fc5e: Implement async refreshing in package-refresh-contents Stefan Monnier
2015-03-31 10:02     ` Artur Malabarba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdUY-KD2Cg1hPdSeZD_JyKt_tA8exwtBCAyw04mmtigw7dkAg@mail.gmail.com \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).