From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/package.el-async-refresh bc0fc5e: Implement async refreshing in package-refresh-contents Date: Tue, 31 Mar 2015 11:02:29 +0100 Message-ID: References: <20150331002109.4237.29402@vcs.savannah.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1427796192 4670 80.91.229.3 (31 Mar 2015 10:03:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 31 Mar 2015 10:03:12 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 31 12:02:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yct0Q-0002Fm-Gx for ged-emacs-devel@m.gmane.org; Tue, 31 Mar 2015 12:02:46 +0200 Original-Received: from localhost ([::1]:37807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yct0K-0000DD-S1 for ged-emacs-devel@m.gmane.org; Tue, 31 Mar 2015 06:02:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yct0B-0000Co-LN for emacs-devel@gnu.org; Tue, 31 Mar 2015 06:02:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yct0A-0003gI-Oq for emacs-devel@gnu.org; Tue, 31 Mar 2015 06:02:31 -0400 Original-Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:34967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yct0A-0003g8-Fz for emacs-devel@gnu.org; Tue, 31 Mar 2015 06:02:30 -0400 Original-Received: by lahf3 with SMTP id f3so8246483lah.2 for ; Tue, 31 Mar 2015 03:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ZmRCmcm0P9e8JaIcbmh10O5X/WBLhgerDwGVOXbSM4U=; b=TNPvi8jQNBUHUdRMQL0NPHff0JUyJ1LiUZ3Ss/HTzzqO/nGghHd0rqzw8p1CEvrnuc Kin6XvBx+jmPZZ0Mt3FP3wjUh6z632za9VdIn0XFEWFGDdxMlkfB6myCyTQxnEhy9knE c3NcnSZ7oT9BwkNoGPeNTjp8A652USgntrcm/I4m1Sz8XTIyxuNi8dEy+CmLezu6d9hM EW5vrlqXi2OQN0wkVCa2a9tuJPh9bPbXOlfMtDizEeXZoR5Yrk7cyLcg9638tGfY2STn SZXxzkvMOKp+S+OpwHW5BLPKSW0LMNAaWwra007hsFn2p/tGTdAyf3nN6Y4MfboNLBZ5 eQsg== X-Received: by 10.112.140.74 with SMTP id re10mr30760118lbb.80.1427796149442; Tue, 31 Mar 2015 03:02:29 -0700 (PDT) Original-Received: by 10.112.207.225 with HTTP; Tue, 31 Mar 2015 03:02:29 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: zR3GNYRaxxLzDIX2Z-QNAzDxHZw X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184599 Archived-At: > I personally would only place a single function on it, tho (which then > calls the above 3 functions). Or I would keep it nil by default, and > just put a call to that (new) function wherever you currently run > package--post-download-archives-hook. Yes, I've changed it to this last one. Makes more sense here. > >> + (add-hook 'package--post-download-archives-hook >> + #'package-menu--populate-new-package-list 'append) >> + (add-hook 'package--post-download-archives-hook >> + #'package-menu--revert 'append) >> + (add-hook 'package--post-download-archives-hook >> + #'package-menu--find-and-notify-upgrades 'append) > > Similarly, here I'd put a single function on the hook which then calls > those 3. Done.