From: Xue Fuqiao <xfq.free@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] trunk r113896: Declare external variables.
Date: Sat, 17 Aug 2013 06:38:46 +0800 [thread overview]
Message-ID: <CAAF+z6HzVUKqbYVETSMx2f0XCScxEKj_V+ekAmCy17b8s1gQ6w@mail.gmail.com> (raw)
In-Reply-To: <871u5uozq5.fsf@gmx.de>
On Fri, Aug 16, 2013 at 3:34 PM, Michael Albinus <michael.albinus@gmx.de> wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> +(eval-when-compile
>>> + (defvar directory-sep-char)
>>> + (defvar dired-move-to-filename-regexp))
>>
>> You don't want to "eval" those defvars, since evaluating such a defvar is
>> mostly a no-op. So don't put them inside eval-when-compile.
> I've written it this way for didactic purposes: it reminds me what it is
> good for (byte-compiler!).
Like Stefan said, it burdens the byte-compiler. You can add some
comments before it.
--
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/
next prev parent reply other threads:[~2013-08-16 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VA0wJ-0001uE-N7@vcs.savannah.gnu.org>
2013-08-15 20:25 ` [Emacs-diffs] trunk r113896: Declare external variables Stefan Monnier
2013-08-16 7:34 ` Michael Albinus
2013-08-16 16:28 ` Stefan Monnier
2013-08-17 10:21 ` Michael Albinus
2013-08-16 22:38 ` Xue Fuqiao [this message]
2013-08-15 20:32 ` Stefan Monnier
2013-08-16 12:46 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAF+z6HzVUKqbYVETSMx2f0XCScxEKj_V+ekAmCy17b8s1gQ6w@mail.gmail.com \
--to=xfq.free@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).