From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Xue Fuqiao Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113896: Declare external variables. Date: Sat, 17 Aug 2013 06:38:46 +0800 Message-ID: References: <871u5uozq5.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1376692740 11266 80.91.229.3 (16 Aug 2013 22:39:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Aug 2013 22:39:00 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 17 00:39:00 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VASfX-0000eJ-9j for ged-emacs-devel@m.gmane.org; Sat, 17 Aug 2013 00:38:55 +0200 Original-Received: from localhost ([::1]:33376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VASfW-0001YK-Te for ged-emacs-devel@m.gmane.org; Fri, 16 Aug 2013 18:38:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VASfR-0001YE-1P for emacs-devel@gnu.org; Fri, 16 Aug 2013 18:38:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VASfP-0002Xm-HQ for emacs-devel@gnu.org; Fri, 16 Aug 2013 18:38:48 -0400 Original-Received: from mail-ie0-x229.google.com ([2607:f8b0:4001:c03::229]:47206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VASfP-0002Wo-Bv for emacs-devel@gnu.org; Fri, 16 Aug 2013 18:38:47 -0400 Original-Received: by mail-ie0-f169.google.com with SMTP id qd12so4404595ieb.14 for ; Fri, 16 Aug 2013 15:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3K1fEryj8oticEOCCZcUcsVP+xi8tJN9e6RRjqnX6vE=; b=HV+7PD2LDeMlvfIOJ4cNQrgoKFZqbqb4kQih7s1fgtgqkXc6i911gHGLjm3eVAatFl fLax3GF/2m9c0XK21xa/ZTWy1lK5HdVC/4BqUaLXF7IHmYuPweaXKxH7gcXdYLMsNvot cA8x27aCNm1Nwf6gZ1s0PRXueHN8YdBHLYfkKJ7gjgB9k3orywz35KjgNXgC0toAG0Vi GK2aB2JaUDZAOXdTCPuYyE19X4BK36O0hY3jfc2IybM1oNZWuWgYzui1J9BjAZA+xHZJ u26B7gkAZQrX3ODEZiaGiChv7CiSbpy4hsxzeGJIkb01tCgoRjC2raKzdTqKV6Z6cAPv qlJg== X-Received: by 10.42.127.199 with SMTP id j7mr2020319ics.20.1376692726706; Fri, 16 Aug 2013 15:38:46 -0700 (PDT) Original-Received: by 10.43.152.207 with HTTP; Fri, 16 Aug 2013 15:38:46 -0700 (PDT) In-Reply-To: <871u5uozq5.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162832 Archived-At: On Fri, Aug 16, 2013 at 3:34 PM, Michael Albinus wrote: > Stefan Monnier writes: > >>> +(eval-when-compile >>> + (defvar directory-sep-char) >>> + (defvar dired-move-to-filename-regexp)) >> >> You don't want to "eval" those defvars, since evaluating such a defvar is >> mostly a no-op. So don't put them inside eval-when-compile. > I've written it this way for didactic purposes: it reminds me what it is > good for (byte-compiler!). Like Stefan said, it burdens the byte-compiler. You can add some comments before it. -- Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/