Re: feature/tree-sitter bb0a427e9d 1/6: * configure.ac (WINDOW_SYSTEM_OBJ): Move tree-sitter placement.

Re: feature/tree-sitter bb0a427e9d 1/6: * configure.ac (WINDOW_SYSTEM_OBJ): Move tree-sitter placement.

[Po Lu]

Yuan Fu <casouri@gmail.com> writes:

> branch: feature/tree-sitter
> commit bb0a427e9d3c29c17c1b03773697989328f53056
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
>     * configure.ac (WINDOW_SYSTEM_OBJ): Move tree-sitter placement.

Is there any partcular reason you wrote WINDOW_SYSTEM_OBJ in the commit
message?

> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4ce7e8b8ce..4b9625c22b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -6591,9 +6591,9 @@ Configured for '${canonical}'.
>  optsep=
>  emacs_config_features=
>  for opt in ACL BE_APP CAIRO DBUS FREETYPE GCONF GIF GLIB GMP GNUTLS GPM GSETTINGS \
> - HARFBUZZ IMAGEMAGICK JPEG JSON TREE-SITTER LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 \
> + HARFBUZZ IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 \
>   M17N_FLT MODULES NATIVE_COMP NOTIFY NS OLDXMENU PDUMPER PGTK PNG RSVG SECCOMP \
> - SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS \
> + SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE-SITTER \

"TREE-SITTER" should be written with an underscore, so it should be
"TREE_SITTER".

Re: feature/tree-sitter bb0a427e9d 1/6: * configure.ac (WINDOW_SYSTEM_OBJ): Move tree-sitter placement.

[Yuan Fu]

> On Oct 28, 2022, at 6:46 AM, Po Lu <luangruo@yahoo.com> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> branch: feature/tree-sitter
>> commit bb0a427e9d3c29c17c1b03773697989328f53056
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>> 
>>    * configure.ac (WINDOW_SYSTEM_OBJ): Move tree-sitter placement.
> 
> Is there any partcular reason you wrote WINDOW_SYSTEM_OBJ in the commit
> message?

That’s my slip-up, I used a command to automatically insert change lot entries without checking.

> 
>> ---
>> configure.ac | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/configure.ac b/configure.ac
>> index 4ce7e8b8ce..4b9625c22b 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -6591,9 +6591,9 @@ Configured for '${canonical}'.
>> optsep=
>> emacs_config_features=
>> for opt in ACL BE_APP CAIRO DBUS FREETYPE GCONF GIF GLIB GMP GNUTLS GPM GSETTINGS \
>> - HARFBUZZ IMAGEMAGICK JPEG JSON TREE-SITTER LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 \
>> + HARFBUZZ IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 \
>>  M17N_FLT MODULES NATIVE_COMP NOTIFY NS OLDXMENU PDUMPER PGTK PNG RSVG SECCOMP \
>> - SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS \
>> + SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE-SITTER \
> 
> "TREE-SITTER" should be written with an underscore, so it should be
> "TREE_SITTER".

I’ll fix that.

Thanks,
Yan