unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Cyril Arnould <cyril.arnould@outlook.com>
To: "Eli Zaretskii" <eliz@gnu.org>,
	"Michael Albinus" <michael.albinus@gmx.de>,
	"Reto Zimmermann" <reto@gnu.org>,
	"Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: AW: emacs-29 a2d4cd06f45: Improve VHDL mode highlighting
Date: Tue, 9 May 2023 11:51:29 +0000	[thread overview]
Message-ID: <AS4PR10MB611014566862DBAE7311B343E3769@AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <83h6slc438.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

> Cyril, are you done discussing this, or do I need to wait some more?

I was actually hoping to get Reto's and/or your input on two
points, the first one being:

> Since this introduces changes in the vhdl-compiler type, I guess
> it would be appropriate to increment the vhdl-version number?

I've seen that on Reto's website, the latest vhdl-version number
is 3.38.4, while in the emacs repository it's at 3.38.1. I'm not
sure if this is intentional or if it simply hasn't been tracked
in emacs. If development is not intended to diverge, we could
skip ahead to 3.38.5 or 3.39.1.

The second point is that we now have two solutions for backwards
compatibility code. There's my original solution which is a
slight modification of already established backwards
compatibility code. Alternatively, there's the solution
elaborated with Mattias which should be safer but is less
tested. If using a more "experimental" solution is no problem
then we can go ahead with the new approach.


[-- Attachment #2: Type: text/html, Size: 2130 bytes --]

  reply	other threads:[~2023-05-09 11:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <168326553347.14898.7329669431232347477@vcs2.savannah.gnu.org>
     [not found] ` <20230505054533.D680AC1BECD@vcs2.savannah.gnu.org>
2023-05-09  7:53   ` emacs-29 a2d4cd06f45: Improve VHDL mode highlighting Michael Albinus
2023-05-09  8:16     ` Eli Zaretskii
2023-05-09 11:51       ` Cyril Arnould [this message]
2023-05-09 14:37         ` AW: " Reto Zimmermann
2023-05-09 15:48           ` AW: " Cyril Arnould
2023-05-10  7:26             ` Cyril Arnould
2023-05-13 13:52               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR10MB611014566862DBAE7311B343E3769@AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM \
    --to=cyril.arnould@outlook.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattias.engdegard@gmail.com \
    --cc=michael.albinus@gmx.de \
    --cc=reto@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).