unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] fix byte-recompile-directory bug
@ 2014-01-02  4:57 Ryan Mulligan
  2014-01-02 19:31 ` Glenn Morris
  0 siblings, 1 reply; 2+ messages in thread
From: Ryan Mulligan @ 2014-01-02  4:57 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

Hello.

This patch fixes the bug I reported earlier today:

emacs -Q --eval "(byte-recompile-directory
\"/home/ryantm/projects/emacs/expand-region.el/\" 0)"

writes

Error: IO error reading /home/ryantm/projects/emacs/expand-region.el: Is a
directory

in the *Compile-Log* buffer and does not compile the files.

patch follows.

Regards
Ryan Mulligan

=== modified file 'lisp/emacs-lisp/bytecomp.el'
--- lisp/emacs-lisp/bytecomp.el 2014-01-01 07:43:34 +0000
+++ lisp/emacs-lisp/bytecomp.el 2014-01-02 04:53:00 +0000
@@ -1598,7 +1598,7 @@
        (while directories
         (setq directory (car directories))
         (message "Checking %s..." directory)
-         (dolist (file (directory-files directory))
+         (dolist (file (delete "." (delete ".." (directory-files
directory))))
            (let ((source (expand-file-name file directory)))
             (if (file-directory-p source)
                 (and (not (member file '("RCS" "CVS")))

[-- Attachment #2: Type: text/html, Size: 3420 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix byte-recompile-directory bug
  2014-01-02  4:57 [PATCH] fix byte-recompile-directory bug Ryan Mulligan
@ 2014-01-02 19:31 ` Glenn Morris
  0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2014-01-02 19:31 UTC (permalink / raw)
  To: Ryan Mulligan; +Cc: emacs-devel

Ryan Mulligan wrote:

> This patch fixes the bug I reported earlier today:

Thaks, but why would you not send the patch to the bug report?

Also, I believe this is already fixed in Emacs trunk:
 http://debbugs.gnu.org/15220



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-02 19:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-02  4:57 [PATCH] fix byte-recompile-directory bug Ryan Mulligan
2014-01-02 19:31 ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).