Contributing other person's work

Contributing other person's work

[조성빈]

I would like to contribute a patch to emacs (which adds Emacs xwidget webkit support for macOS Cocoa), but most of it was developed by another person (I just updated the patch periodically as some Emacs internals changed); see https://github.com/veshboo/emacs

He indicated his intention to contribute to mainline (see https://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00662.html and associated messages); and a comment in one of his issues (see https://github.com/veshboo/emacs/issues/5#issuecomment-421777014) indicates that if veshboo(Jaesup Kwak) signed his FSF copyright assignment,  others can do the integration for him.

Is this true? (If it’s true) Is there a way to check if one has signed the FSF copyright assignment?

Re: Contributing other person's work

[Stefan Monnier]

> I would like to contribute a patch to emacs (which adds Emacs xwidget webkit
> support for macOS Cocoa), but most of it was developed by another person (I
> just updated the patch periodically as some Emacs internals changed); see
> https://github.com/veshboo/emacs

Great!

> He indicated his intention to contribute to mainline (see
> https://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00662.html and
> associated messages); and a comment in one of his issues (see
> https://github.com/veshboo/emacs/issues/5#issuecomment-421777014) indicates
> that if veshboo(Jaesup Kwak) signed his FSF copyright assignment,  others
> can do the integration for him.

Good.

> Is this true?

Yes, of course.

> (If it’s true) Is there a way to check if one has signed the FSF copyright assignment?

He has: it's on file and everything.


        Stefan

Re: Contributing other person's work

[Paul Eggert]

조성빈 wrote:
> Is there a way to check if one has signed the FSF copyright assignment?

Yes, I just now checked and Jaesup Kwak signed the agreement for Emacs.

Re: Contributing other person's work

[조성빈]

> 2019. 5. 20. 오전 1:39, Paul Eggert <eggert@cs.ucla.edu> 작성:
> 
> 조성빈 wrote:
>> Is there a way to check if one has signed the FSF copyright assignment?
> 
> Yes, I just now checked and Jaesup Kwak signed the agreement for Emacs.

Does this mean that I can contribute code that Jaesup Kwak & I wrote?

Re: Contributing other person's work

[조성빈]

> 2019. 5. 20. 오전 1:39, Stefan Monnier <monnier@iro.umontreal.ca> 작성:
> 
>> I would like to contribute a patch to emacs (which adds Emacs xwidget webkit
>> support for macOS Cocoa), but most of it was developed by another person (I
>> just updated the patch periodically as some Emacs internals changed); see
>> https://github.com/veshboo/emacs
> 
> Great!

How does the workflow work exactly?̊̈
If I send the patch by email, does one of the core contributors apply the patch onto the current HEAD of remote?

>> He indicated his intention to contribute to mainline (see
>> https://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00662.html and
>> associated messages); and a comment in one of his issues (see
>> https://github.com/veshboo/emacs/issues/5#issuecomment-421777014) indicates
>> that if veshboo(Jaesup Kwak) signed his FSF copyright assignment,  others
>> can do the integration for him.
> 
> Good.
> 
>> Is this true?
> 
> Yes, of course.

That’s relieving :-)

>> (If it’s true) Is there a way to check if one has signed the FSF copyright assignment?
> 
> He has: it's on file and everything.

As I haven’t signed before, can I ask how to sign the copyright assignment?

> 
> 
>        Stefan
> 
> 

Re: Contributing other person's work

[Paul Eggert]

조성빈 wrote:
> Does this mean that I can contribute code that Jaesup Kwak & I wrote?

Yes, if you also sign the copyright papers.

Re: Contributing other person's work

[Stefan Monnier]

> How does the workflow work exactly?̊̈
> If I send the patch by email, does one of the core contributors apply the
> patch onto the current HEAD of remote?

Yes, that's one way.  Another is to point to a Git branch.
I'm not sure whether we want the faithful commit history in this case:
I usually like it, but if there's been too many "merge from master"
that end up drowning the real commits, it might be worth the trouble of
reworking the history a bit (e.g. going back to the last real commit
merge that into master).  Also, the commit messages may require
improvements, which would again require rewriting the history.

>> He has: it's on file and everything.
> As I haven’t signed before, can I ask how to sign the copyright assignment?

Sure: fill the form below and email it as instructed to the FSF so they
can send you the relevant paperwork to sign,


        Stefan


Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]


[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]


[For the copyright registration, what country are you a citizen of?]


[What year were you born?]


[Please write your email address here.]


[Please write your postal address here.]





[Which files have you changed so far, and which new files have you written
so far?]

Re: Contributing other person's work

[조성빈]

> 2019. 5. 20. 오전 1:51, Stefan Monnier <monnier@iro.umontreal.ca> 작성:
> 
>> How does the workflow work exactly?̊̈
>> If I send the patch by email, does one of the core contributors apply the
>> patch onto the current HEAD of remote?
> 
> Yes, that's one way.  Another is to point to a Git branch.
> I'm not sure whether we want the faithful commit history in this case:
> I usually like it, but if there's been too many "merge from master"
> that end up drowning the real commits, it might be worth the trouble of
> reworking the history a bit (e.g. going back to the last real commit
> merge that into master).  Also, the commit messages may require
> improvements, which would again require rewriting the history.

I would like the patch workflow better as I was maintaining the patch only :-)

>>> He has: it's on file and everything.
>> As I haven’t signed before, can I ask how to sign the copyright assignment?
> 
> Sure: fill the form below and email it as instructed to the FSF so they
> can send you the relevant paperwork to sign,

Before I have to wait two weeks to get my paperwork (and it’s hard to get my paperwork as mail here for special reasons...),
I think(maybe not) I heard a news a year or two ago that FSF started to allowing digital signing with gpg…
Is that true? If it is, I would prefer the digital-way…

> 
>        Stefan
> 
> 
> Please email the following information to assign@gnu.org, and we
> will send you the assignment form for your past and future changes.
> 
> Please use your full legal name (in ASCII characters) as the subject
> line of the message.
> ----------------------------------------------------------------------
> REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES
> 
> [What is the name of the program or package you're contributing to?]
> Emacs
> 
> [Did you copy any files or text written by someone else in these changes?
> Even if that material is free software, we need to know about it.]
> 
> 
> [Do you have an employer who might have a basis to claim to own
> your changes?  Do you attend a school which might make such a claim?]
> 
> 
> [For the copyright registration, what country are you a citizen of?]
> 
> 
> [What year were you born?]
> 
> 
> [Please write your email address here.]
> 
> 
> [Please write your postal address here.]
> 
> 
> 
> 
> 
> [Which files have you changed so far, and which new files have you written
> so far?]
> 

Re: Contributing other person's work

[Stefan Monnier]

> Before I have to wait two weeks to get my paperwork (and it’s hard to get my
> paperwork as mail here for special reasons...),
> I think(maybe not) I heard a news a year or two ago that FSF started to
> allowing digital signing with gpg…
> Is that true? If it is, I would prefer the digital-way…

The guy behind assign@gnu.org (probably Donald) will let you know how it
works.  Just like you, they prefer the digital way when it can be done
(depends on various details such a countries), so there's no need to
ask specifically.


        Stefan

Re: Contributing other person's work

[Alan Third]

On Mon, May 20, 2019 at 12:37:01AM +0900, 조성빈 wrote:
> I would like to contribute a patch to emacs (which adds Emacs
> xwidget webkit support for macOS Cocoa), but most of it was
> developed by another person (I just updated the patch periodically
> as some Emacs internals changed); see
> https://github.com/veshboo/emacs

I’d wondered what was happening with this. I’m glad to hear it’s going
to make it into Emacs.
-- 
Alan Third