unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] master c7abc57: Tweak nnimap sequence numbers to avoid reuse
       [not found] ` <20180413114140.787CC20101@vcs0.savannah.gnu.org>
@ 2018-04-13 14:42   ` Stefan Monnier
  2018-04-13 14:50     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2018-04-13 14:42 UTC (permalink / raw)
  To: emacs-devel; +Cc: Lars Ingebrigtsen

Hi Lars,

>     Tweak nnimap sequence numbers to avoid reuse
>     
>     * lisp/gnus/nnimap.el (nnimap-sequence): Start the sequence at a
>     higher number to avoid reusing the sequence number used by
>     `open-network-stream' (bug#30022).
[...]
> -(defvar nnimap-sequence 0)
> +(defvar nnimap-sequence 5)

The commit message's info would have been better placed as a comment in
the code, I think.


        Stefan



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Emacs-diffs] master c7abc57: Tweak nnimap sequence numbers to avoid reuse
  2018-04-13 14:42   ` [Emacs-diffs] master c7abc57: Tweak nnimap sequence numbers to avoid reuse Stefan Monnier
@ 2018-04-13 14:50     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2018-04-13 14:50 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Hi Lars,
>
>>     Tweak nnimap sequence numbers to avoid reuse
>>     
>>     * lisp/gnus/nnimap.el (nnimap-sequence): Start the sequence at a
>>     higher number to avoid reusing the sequence number used by
>>     `open-network-stream' (bug#30022).
> [...]
>> -(defvar nnimap-sequence 0)
>> +(defvar nnimap-sequence 5)
>
> The commit message's info would have been better placed as a comment in
> the code, I think.

Yup; fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-13 14:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20180413114139.370.32795@vcs0.savannah.gnu.org>
     [not found] ` <20180413114140.787CC20101@vcs0.savannah.gnu.org>
2018-04-13 14:42   ` [Emacs-diffs] master c7abc57: Tweak nnimap sequence numbers to avoid reuse Stefan Monnier
2018-04-13 14:50     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).