Re: master 893111f 2/2: Hide passwords in .authinfo and .netrc files

Re: master 893111f 2/2: Hide passwords in .authinfo and .netrc files

[Amin Bandali]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> +      (while (re-search-forward "\\bpassword +\\([^\n\t ]+\\)"

Would it make more sense to use '\s-' rather than '\b' here?  With '\b',
it will match the ‘password’ in an entry like `gnus-canlock-password'
and thus wrongly add the display property to the next word, in this case
“password”, rather than to the actual password itself.

Re: master 893111f 2/2: Hide passwords in .authinfo and .netrc files

[Lars Ingebrigtsen]

Amin Bandali <bandali@gnu.org> writes:

> larsi@gnus.org (Lars Ingebrigtsen) writes:
>
>> +      (while (re-search-forward "\\bpassword +\\([^\n\t ]+\\)"
>
> Would it make more sense to use '\s-' rather than '\b' here?  With '\b',
> it will match the ‘password’ in an entry like `gnus-canlock-password'
> and thus wrongly add the display property to the next word, in this case
> “password”, rather than to the actual password itself.

Good point.  I used \\b because I was thinking about whether "password"
could be the first token on a the line, but I've now changed the regexp
to be

"\\(\\s-\\|^\\)password\\s-+\\([^\n\t ]+\\)"

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 893111f 2/2: Hide passwords in .authinfo and .netrc files

[Amin Bandali]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Amin Bandali <bandali@gnu.org> writes:
>
>> larsi@gnus.org (Lars Ingebrigtsen) writes:
>>
>>> +      (while (re-search-forward "\\bpassword +\\([^\n\t ]+\\)"
>>
>> Would it make more sense to use '\s-' rather than '\b' here?  With '\b',
>> it will match the ‘password’ in an entry like `gnus-canlock-password'
>> and thus wrongly add the display property to the next word, in this case
>> “password”, rather than to the actual password itself.
>
> Good point.  I used \\b because I was thinking about whether "password"
> could be the first token on a the line, but I've now changed the regexp
> to be
>
> "\\(\\s-\\|^\\)password\\s-+\\([^\n\t ]+\\)"

Works well now, thanks!

On a side note, I wonder it would be too much to have the keyword(s) be
customizeable?  For instance, I use my authinfo file to store entries
with multiple “secret” parts, such as the following:

machine xyz client-id 62308.619 client-secret ce2e92 token x-27f57e9a

It would be nice if there were a defcustom e.g. `authinfo-hidden-parts',
defaulting to “password”, which one could add other keywords to, such as
“client-secret” and “token”.

Re: master 893111f 2/2: Hide passwords in .authinfo and .netrc files

[Lars Ingebrigtsen]

Amin Bandali <bandali@gnu.org> writes:

> On a side note, I wonder it would be too much to have the keyword(s) be
> customizeable?  For instance, I use my authinfo file to store entries
> with multiple “secret” parts, such as the following:
>
> machine xyz client-id 62308.619 client-secret ce2e92 token x-27f57e9a
>
> It would be nice if there were a defcustom e.g. `authinfo-hidden-parts',
> defaulting to “password”, which one could add other keywords to, such as
> “client-secret” and “token”.

Yes, makes sense.  Should that just be a list of tokens, or a regexp?
If a regexp, I guess the function would have to be somewhat more
rewritten to keep the bit that matches the secret bit in the right
regexp grouping...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 893111f 2/2: Hide passwords in .authinfo and .netrc files

[Amin Bandali]

Lars Ingebrigtsen <larsi@gnus.org> writes:

[...]
> Yes, makes sense.  Should that just be a list of tokens, or a regexp?
> If a regexp, I guess the function would have to be somewhat more
> rewritten to keep the bit that matches the secret bit in the right
> regexp grouping...

Cool.  I think having a regexp would be great in terms of flexibility,
but maybe not if it causes too much added complexity?  Having a list
would probably be simpler to implement and/or use.  But of course, if we
do go with a regexp, the user could always use C-h f regexp-opt RET to
automatically generate a regexp from a list of strings, rather than
hand-write it.  I guess my vote would be a regexp, if it doesn’t make
authinfo--hide-passwords overly complicated.

Thanks for working on this, Lars.

Re: master 893111f 2/2: Hide passwords in .authinfo and .netrc files

[Lars Ingebrigtsen]

Amin Bandali <bandali@gnu.org> writes:

> I guess my vote would be a regexp, if it doesn’t make
> authinfo--hide-passwords overly complicated.

No, it was more straightforward than I thought, so I've now done this on
the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 893111f 2/2: Hide passwords in .authinfo and .netrc files

[Amin Bandali]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Amin Bandali <bandali@gnu.org> writes:
>
>> I guess my vote would be a regexp, if it doesn’t make
>> authinfo--hide-passwords overly complicated.
>
> No, it was more straightforward than I thought, so I've now done this on
> the trunk.

Works great, thanks again!