From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: emacs-devel@gnu.org
Cc: Stefan Kangas <stefankangas@gmail.com>
Subject: Re: master 80abaea: Use lexical-binding in lunar.el and add tests
Date: Sat, 13 Jun 2020 19:52:24 +0100 [thread overview]
Message-ID: <87zh9623yv.fsf@tcd.ie> (raw)
In-Reply-To: <87r1uqo7cq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 07 Jun 2020 23:10:13 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> stefankangas@gmail.com (Stefan Kangas) writes:
>
>> branch: master
>> commit 80abaea1d9c6f1e53fe88befe16de3b219cdd919
>> Author: Stefan Kangas <stefankangas@gmail.com>
>> Commit: Stefan Kangas <stefankangas@gmail.com>
>>
>> Use lexical-binding in lunar.el and add tests
>>
>> * lisp/calendar/lunar.el: Use lexical-binding.
>> (lunar-phases, diary-lunar-phases): Silence byte-compiler.
>> * test/lisp/calendar/lunar-tests.el: New file.
>
> I'm seeing the following test failure:
>
> cd test; make lunar-tests
[...]
> Test lunar-test-phase-list condition:
> (ert-test-failed
> ((should
> (equal
> (lunar-phase-list 3 1871)
> '...))
> :form
> (equal
> ((... "9:03pm" 0 "")
> (... "11:46pm" 1 "** Eclipse **")
> (... "7:20am" 2 "")
> (... "10:57pm" 3 "** Eclipse possible **")
> (... "12:06pm" 0 "")
> (... "4:49pm" 1 "")
> (... "3:57pm" 2 "")
> (... "7:29am" 3 "")
> (... "3:46am" 0 "")
> (... "6:02am" 1 ""))
> ((... "11:03pm" 0 "")
> (... "1:46am" 1 "** Eclipse **")
> (... "9:20am" 2 "")
> (... "12:57am" 3 "** Eclipse possible **")
> (... "2:06pm" 0 "")
> (... "6:49pm" 1 "")
> (... "5:57pm" 2 "")
> (... "9:29am" 3 "")
> (... "5:46am" 0 "")
> (... "8:02am" 1 "")))
> :value nil :explanation
> (list-elt 0
> (list-elt 1
> (arrays-of-different-length 6 7 "9:03pm" "11:03pm" first-mismatch-at 0)))))
[...]
> In case it matters, my time zone is
>
> (format-time-string "%Z %z") ; => "IST +0100"
Looks like I'm not the only one:
Tag a test as unstable
4823fa1077 2020-06-13 10:42:47 -0700
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4823fa1077e4330bd2574eb54731bb32e6370034
--
Basil
prev parent reply other threads:[~2020-06-13 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200607190128.16579.5580@vcs0.savannah.gnu.org>
[not found] ` <20200607190130.38C4E20A2E@vcs0.savannah.gnu.org>
2020-06-07 22:10 ` master 80abaea: Use lexical-binding in lunar.el and add tests Basil L. Contovounesios
2020-06-08 6:49 ` Stefan Kangas
2020-06-13 18:52 ` Basil L. Contovounesios [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh9623yv.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).