From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 80abaea: Use lexical-binding in lunar.el and add tests Date: Sat, 13 Jun 2020 19:52:24 +0100 Message-ID: <87zh9623yv.fsf@tcd.ie> References: <20200607190128.16579.5580@vcs0.savannah.gnu.org> <20200607190130.38C4E20A2E@vcs0.savannah.gnu.org> <87r1uqo7cq.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="94415"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 13 20:53:05 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkBH7-000ORM-RN for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 20:53:05 +0200 Original-Received: from localhost ([::1]:40076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkBH6-0005TM-Qk for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 14:53:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkBGa-00054M-86 for emacs-devel@gnu.org; Sat, 13 Jun 2020 14:52:32 -0400 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:41768) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkBGY-0006yO-7P for emacs-devel@gnu.org; Sat, 13 Jun 2020 14:52:31 -0400 Original-Received: by mail-wr1-x42f.google.com with SMTP id j10so13101512wrw.8 for ; Sat, 13 Jun 2020 11:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jl9gR4cAblFzYpuyeZ7NvVpfpZT1zDBR9iIDpKp5YTo=; b=V17NjVxBtHtaUUhitHBUCgITH/Ae6bR0kF0xyiADwhcaynVbl+OLtgD3TlA+OLczAH xybrSe0mxUG2+nZLFNv9BVw8+VFEOyPQVgqGpw3cF/o+dLvf58F913MSuLktIx7DzOel PD1u6dZDsGozvBM41BTbHAqEUqTe2zKcUf/CIZtlfc3xirIUAPcu9OVYp6IKHzNxVmng mVpt1v/ul05zIyxiEtRdlM2m2NBAjUClnLdU04d2DJnan4v8cE6k/Bm6gx+EwxJSsJ45 cVPmcFMsDVAxljJ+iUPHlT3aJda4U2iE4KCXeP/CzlecA0hQkb0aBzebJLMWBmPjOyEr TV/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jl9gR4cAblFzYpuyeZ7NvVpfpZT1zDBR9iIDpKp5YTo=; b=igXUeDX78bdXAitQA7n0Z/jsLrC0M1beKphiXL/Ln2e7btxtrZv8VT7S2Y338smV88 h1RMDNYbZiLD7/BTNtUnwQYG0VBKBY24flRqoJ8OCK+TyVOCLuV2nvnWghFAkJfAoeB4 ninkV8/55QwvTYor3F8vtVGRHbeHlnf0d1CP9c3DvhapUlo3Mi9J5DtTwmLGdgqAPMRl YjesbNDxx546sKeEbFjyEWFMM07RqY3m8I3qD15drIvkU2CmSAlTAMZXL4KGp4OAkYKG Qg6D1YlO1mUF8lF+iPi+6JN/qQnqaOES2BSH8AZ229GJqMBiazVPJl3Ey3nhobfAhIuv UsSg== X-Gm-Message-State: AOAM533Qmv8St+mzqeBeJuAZhWWoDWwGNtvuqsfO6H2V685uk+qvPsGO 8waLduBSYFVc3IQqBciD40CHYSUA9dCEIw== X-Google-Smtp-Source: ABdhPJwn4doldW8YFB4zGUVdNRbGT+nulyY8v9eP/PMIBislD2Nt5O/lqzLTW4v8E4dWxU7m9vg/TA== X-Received: by 2002:adf:fd4b:: with SMTP id h11mr20433708wrs.209.1592074346581; Sat, 13 Jun 2020 11:52:26 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id k16sm16747937wrp.66.2020.06.13.11.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 11:52:25 -0700 (PDT) In-Reply-To: <87r1uqo7cq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 07 Jun 2020 23:10:13 +0100") Received-SPF: none client-ip=2a00:1450:4864:20::42f; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252198 Archived-At: "Basil L. Contovounesios" writes: > stefankangas@gmail.com (Stefan Kangas) writes: > >> branch: master >> commit 80abaea1d9c6f1e53fe88befe16de3b219cdd919 >> Author: Stefan Kangas >> Commit: Stefan Kangas >> >> Use lexical-binding in lunar.el and add tests >> >> * lisp/calendar/lunar.el: Use lexical-binding. >> (lunar-phases, diary-lunar-phases): Silence byte-compiler. >> * test/lisp/calendar/lunar-tests.el: New file. > > I'm seeing the following test failure: > > cd test; make lunar-tests [...] > Test lunar-test-phase-list condition: > (ert-test-failed > ((should > (equal > (lunar-phase-list 3 1871) > '...)) > :form > (equal > ((... "9:03pm" 0 "") > (... "11:46pm" 1 "** Eclipse **") > (... "7:20am" 2 "") > (... "10:57pm" 3 "** Eclipse possible **") > (... "12:06pm" 0 "") > (... "4:49pm" 1 "") > (... "3:57pm" 2 "") > (... "7:29am" 3 "") > (... "3:46am" 0 "") > (... "6:02am" 1 "")) > ((... "11:03pm" 0 "") > (... "1:46am" 1 "** Eclipse **") > (... "9:20am" 2 "") > (... "12:57am" 3 "** Eclipse possible **") > (... "2:06pm" 0 "") > (... "6:49pm" 1 "") > (... "5:57pm" 2 "") > (... "9:29am" 3 "") > (... "5:46am" 0 "") > (... "8:02am" 1 ""))) > :value nil :explanation > (list-elt 0 > (list-elt 1 > (arrays-of-different-length 6 7 "9:03pm" "11:03pm" first-mismatch-at 0))))) [...] > In case it matters, my time zone is > > (format-time-string "%Z %z") ; => "IST +0100" Looks like I'm not the only one: Tag a test as unstable 4823fa1077 2020-06-13 10:42:47 -0700 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4823fa1077e4330bd2574eb54731bb32e6370034 -- Basil