From: Po Lu <luangruo@yahoo.com>
To: Fejfighter <fejfighter@gmail.com>
Cc: emacs-devel@gnu.org, Yuuki Harano <masm+github@masm11.me>
Subject: Re: [PATCH] PGTK patches
Date: Mon, 15 Nov 2021 13:25:37 +0800 [thread overview]
Message-ID: <87zgq60z3i.fsf@yahoo.com> (raw)
In-Reply-To: <CALohuRDosMzAf0DB_N8ZbNSE0t9R0eusGvyZjmthjjL6KiM6=w@mail.gmail.com> (fejfighter@gmail.com's message of "Sun, 14 Nov 2021 23:34:51 +1100")
Fejfighter <fejfighter@gmail.com> writes:
> + gtk_widget_grab_focus(FRAME_GTK_WIDGET(f));
> + if (FRAME_GTK_OUTER_WIDGET(f))
These two lines are redundant. If a button event is received, there has
to be an outer widget, and gtk_widget_grab_focus only sets the
GtkWindow's input focus, which shouldn't be necessary because
FRAME_GTK_WIDGET is the default widget.
> + gtk_window_present(GTK_WINDOW(FRAME_GTK_OUTER_WIDGET(f)));
This by itself should be enough. Thanks.
prev parent reply other threads:[~2021-11-15 5:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 12:34 [PATCH] PGTK patches Fejfighter
2021-11-14 13:42 ` Yuuki Harano
2021-11-15 5:25 ` Po Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgq60z3i.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=fejfighter@gmail.com \
--cc=masm+github@masm11.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).