From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] PGTK patches Date: Mon, 15 Nov 2021 13:25:37 +0800 Message-ID: <87zgq60z3i.fsf@yahoo.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22009"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org, Yuuki Harano To: Fejfighter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 15 06:26:58 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmUWA-0005Xq-Th for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Nov 2021 06:26:58 +0100 Original-Received: from localhost ([::1]:50604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmUW9-0003rp-3b for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Nov 2021 00:26:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmUV5-00038x-Re for emacs-devel@gnu.org; Mon, 15 Nov 2021 00:25:51 -0500 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]:35674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmUV3-0003mH-FA for emacs-devel@gnu.org; Mon, 15 Nov 2021 00:25:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636953947; bh=Qsp5Bf5zHx+B+FA2mmyhrjCkEzD0yjeHf0bNxn3NF54=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=T3sZU1IG04/BTKfgmNu/G5Vslt0BTWEXUYt3UqVHI73bZCookmuPpc2EtwBqqlaG/TJlGTTxqk3Ym9+2ruM2weY318MygY5NcwmP57ajWqwFbek7w1tgbMAmeZ6IC4PhYcqK8ACEkjKyU2kxB/jagX2CvY6bjaiITlVQyoEvIQGRMQLRW4ETpes2dF+Goz4nKoZOjoZiHYkP/GpM9qW17thGXxfCHBDt1piKmfqUwXCUdx3oTI3oKUQjzaxiArslpfaFlI0hg+kBKH1KhfhIXGkH4Cw9CzZABzzS93Q1gjw3mxRG3C8nmMH69s9gWRxE1CfzMnzeSGy7JMXcdRbvGw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636953947; bh=5awxAxPUNmhdZYJ+LP9Mr7srd3X991JaCWTRemTuXUO=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=LlPUUSi9s5kED1FGEtDKW5xGowTZC/RkG+mwOPRhCZ1LwAIwmpoGXCBrq2jxJ353/B7FmpIGST+lu06HPDLRUFyidPLe2fsE/45aw8wF9j8aDRU6f0HleJRqYVCbSZ31w6HYX6hRJZNxklEz4tGT/g3JMLRLRkMxnxZYwsZaJrLBZ+Yrg/jiW0eW5xKHT2NkXfU6JAKirHpa/xwCBjjByO5tJoI05PRFNPs4KewIeRTRSaTL1I84TTspEXv5BjxoJt4DYnPXR/uPUoxpI7j6ExFsX/AghV7D8ppUBI3razevuEvdJWMgo9Kfr9Kb6QOR6QaoOEOTlIlQsuwx8vEoIQ== X-YMail-OSG: 5GEQwc0VM1mbKQ_s3loD_5uLlX6FpBJFjY9fJzSKOtSTHD12fnfRFPMhLDjrVly Xvqp9McCo8xR8_nh.pmwZFOAFpRYYVFtaHocH0JwqRem5I07RSBfrwagq5lWbjiSnMeHFVpqrs9l PhFnz1xj18z3n2MPflArmK4.rIO.CJb94goODjjkmz24FpGuv5ggKte2dab71CWNpMc7OkoS8aGT HJoxWEERDiaxTQ2SBJXYIq9UOgVJTHX3Ab.tKTj3ghCCQjFnFXLTYFMJ6U4.1n.IWNVzrInCmMA6 EwajpjahF07c6KwKzitu1jnH7cpbnbQJnF5.1ttm1zgwU.yBSvfdDW1YVuzGU_r_vcnW4MNNg6Kf _KbxcChmQ7ZyKNlZQbWWHheLYuD8VoalZDk37exZBEp_aFgQeXTygiiW572t.YZTzoX8Di00hvLA Kn.rIV6VZQ84oAjJSUN5.1Gr0taSrXQDtrmzpsTopG_iBZMKuosRuTlqdPTMzRpuBGtoOkXIB8bJ hoCCeOwv2SyTUyjmwzYqXuTaeVHpFCtdQyjZkcPEPbR.VQodMUC9ozbcL8BQw7X39xWUlQZZql55 j8MSEG3vYsF4.cFN7Jv7Dgwy8unUL3kNMhXHk5e1.hcdWblvI8kbZI4zKDbX8stTzlx1XyD.TRXg 8bIgN14c2DUkj8YsXk0SswAa30i3sc5uFtZCLWnqvFdTo.GjgJn83wEm7y5NgNlvL._BBt2qxsDj roUT_.5dI8ZtF2sHOmUaVMhrI.hlzcDIn9luJyB15JAbENulilSnMh.bAdJd9hOvUC0MfsnoPXeC U4fV2NaEgCZ8HS9Jw6VDiG_BRMoAjHfG5YPBdAfP48 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Mon, 15 Nov 2021 05:25:47 +0000 Original-Received: by kubenode503.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 53ed5966102a6d64d628bb839c155f2c; Mon, 15 Nov 2021 05:25:41 +0000 (UTC) In-Reply-To: (fejfighter@gmail.com's message of "Sun, 14 Nov 2021 23:34:51 +1100") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.33; envelope-from=luangruo@yahoo.com; helo=sonic307-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279466 Archived-At: Fejfighter writes: > + gtk_widget_grab_focus(FRAME_GTK_WIDGET(f)); > + if (FRAME_GTK_OUTER_WIDGET(f)) These two lines are redundant. If a button event is received, there has to be an outer widget, and gtk_widget_grab_focus only sets the GtkWindow's input focus, which shouldn't be necessary because FRAME_GTK_WIDGET is the default widget. > + gtk_window_present(GTK_WINDOW(FRAME_GTK_OUTER_WIDGET(f))); This by itself should be enough. Thanks.