* Re: master ad442b8: Make all vc-*-responsible-p functions return a string
[not found] ` <20211114013900.254D7209C6@vcs0.savannah.gnu.org>
@ 2021-11-14 8:26 ` Stefan Kangas
2021-11-14 8:41 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-11-14 8:26 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Emacs developers
Lars Ingebrigtsen <larsi@gnus.org> writes:
> branch: master
> commit ad442b8887eb08cf125797863bd992792cb4ac4a
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Make all vc-*-responsible-p functions return a string
I believe this broke a test:
1 unexpected results:
FAILED vc-test-cvs01-register
5 skipped results:
SKIPPED vc-test-cvs02-state
SKIPPED vc-test-cvs03-working-revision
SKIPPED vc-test-cvs04-checkout-model
SKIPPED vc-test-cvs05-rename-file
SKIPPED vc-test-cvs06-version-diff
make[3]: *** [Makefile:186: lisp/vc/vc-tests.log] Error 1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master ad442b8: Make all vc-*-responsible-p functions return a string
2021-11-14 8:26 ` master ad442b8: Make all vc-*-responsible-p functions return a string Stefan Kangas
@ 2021-11-14 8:41 ` Lars Ingebrigtsen
2021-11-15 13:21 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-11-14 8:41 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Emacs developers
Stefan Kangas <stefan@marxist.se> writes:
> I believe this broke a test:
>
> 1 unexpected results:
> FAILED vc-test-cvs01-register
Yup. Should be fixed now.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master ad442b8: Make all vc-*-responsible-p functions return a string
2021-11-14 8:41 ` Lars Ingebrigtsen
@ 2021-11-15 13:21 ` Dmitry Gutov
2021-11-16 7:36 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2021-11-15 13:21 UTC (permalink / raw)
To: Lars Ingebrigtsen, Stefan Kangas; +Cc: Emacs developers
On 14.11.2021 11:41, Lars Ingebrigtsen wrote:
> Stefan Kangas<stefan@marxist.se> writes:
>
>> I believe this broke a test:
>>
>> 1 unexpected results:
>> FAILED vc-test-cvs01-register
> Yup. Should be fixed now.
FWIW, -responsible-p is documented to return non-nil rather than a
particular string, at the top of vc.el.
So it was the previous change that was (osensibly) broken, since we'd
generally use vc-root-dir to fetch said strings.
But I suppose this is a good change if it removes the need to hit the
disk twice. The description of 'responsible-p' needs to be updated,
though. Perhaps also describe what values can be returned by backends
which do not support 'root'.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master ad442b8: Make all vc-*-responsible-p functions return a string
2021-11-15 13:21 ` Dmitry Gutov
@ 2021-11-16 7:36 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-11-16 7:36 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Stefan Kangas, Emacs developers
Dmitry Gutov <dgutov@yandex.ru> writes:
> But I suppose this is a good change if it removes the need to hit the
> disk twice. The description of 'responsible-p' needs to be updated,
> though. Perhaps also describe what values can be returned by backends
> which do not support 'root'.
Yup.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-16 7:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211114013858.24577.64348@vcs0.savannah.gnu.org>
[not found] ` <20211114013900.254D7209C6@vcs0.savannah.gnu.org>
2021-11-14 8:26 ` master ad442b8: Make all vc-*-responsible-p functions return a string Stefan Kangas
2021-11-14 8:41 ` Lars Ingebrigtsen
2021-11-15 13:21 ` Dmitry Gutov
2021-11-16 7:36 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).