unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: master 30dbdecd4a: * src/xterm.c: Add a small writeup on input handling on X.
Date: Tue, 01 Mar 2022 08:40:13 +0800	[thread overview]
Message-ID: <87zgma33pu.fsf@yahoo.com> (raw)
In-Reply-To: <c5b3a3d4-a192-4733-179a-77557b2d975d@gmx.at> (martin rudalics's message of "Mon, 28 Feb 2022 16:50:29 +0100")

martin rudalics <rudalics@gmx.at> writes:

> While we're there: If I'm not mistaken, xg_frame_set_char_size now has
> three instances of
>
> #ifndef HAVE_PGTK
>       gtk_window_resize (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)),
> 			 outer_width, outer_height);
> #else
>       if (FRAME_GTK_OUTER_WIDGET (f))
> 	{
> 	  gtk_window_resize (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)),
> 			     outer_width, outer_height);
> 	}
>       else
> 	{
> 	  gtk_widget_set_size_request (FRAME_GTK_WIDGET (f),
> 				       outer_width, outer_height);
> 	}
> #endif
>
> Could you please refactor these into a separate routine and/or at least
> remove those extra braces.

I'm not sure what those are for, but I will look into that.

Thanks.




  reply	other threads:[~2022-03-01  0:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164216105411.7395.2418079616938679655@vcs2.savannah.gnu.org>
     [not found] ` <20220114115054.720EBC0DA2E@vcs2.savannah.gnu.org>
2022-01-14 11:57   ` master 30dbdecd4a: * src/xterm.c: Add a small writeup on input handling on X Po Lu
2022-01-15  9:31     ` martin rudalics
2022-01-15 10:10       ` Po Lu
2022-02-28 15:40     ` martin rudalics
2022-02-28 15:50       ` martin rudalics
2022-03-01  0:40         ` Po Lu [this message]
2022-03-01  0:43       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgma33pu.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).