From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 30dbdecd4a: * src/xterm.c: Add a small writeup on input handling on X. Date: Tue, 01 Mar 2022 08:40:13 +0800 Message-ID: <87zgma33pu.fsf@yahoo.com> References: <164216105411.7395.2418079616938679655@vcs2.savannah.gnu.org> <20220114115054.720EBC0DA2E@vcs2.savannah.gnu.org> <87r19afs1z.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22750"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 01 01:46:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOqep-0005h9-5I for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Mar 2022 01:46:27 +0100 Original-Received: from localhost ([::1]:58660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOqen-0006vv-J2 for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Feb 2022 19:46:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOqZ3-0005rT-Ul for emacs-devel@gnu.org; Mon, 28 Feb 2022 19:40:32 -0500 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]:39953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOqZ0-0004HI-6c for emacs-devel@gnu.org; Mon, 28 Feb 2022 19:40:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646095223; bh=MN8ljxNNhTPZSdmLeBFlP2q5Ezu4diJGeVTyN4GLLyI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=hdekfyoUfKtjt8fXnO6ugR3SoxUUAWBCCMMvgfgpv8AZXMqBhfhcgFvs1e7eI9yiWbOVxOWju9hNL5ffitGGMMLw5Jvx5ymmb4oWE5nRWdAAXYKEVfrbiJSSEQ0opEeyZV10z+bujsojfT1AAIp1vKdjwu7kX0MbAIWfge2BUj5bH2iDtAwFuwAIM8ieVK74+ZwlZL49p6gzcEMj1WFCtQmZW/+qIpG6ZzB2wsoitIO4XJng446YM54s9pM0HR3Nva97R7UJLlbkX/Ir2LD69k7YSwHjcxWJXWqcith3lwceL3gfp9mZheFNuuw8KFkHRzJ9Oe44TPa0artDVQ6lOg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646095223; bh=/9kUD6243MNrZffi39+IXXeAf22te+7NA2Enq0gNksE=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=KPmL+1p7bIsi9BYzbLfkL44djctZY41t171t8yUZeAOBKhj0mSxXS47yX/DYnH2huTqvJMLCX5BHOrkJD6vfFix83oia084i+Don/6RkuMjNGsi7jtNDFDJgJ7SGp4JKk/8GjOqWowY2/qp+W4VqOgFvzfQKDZIzVyxbWzBwnzVMXhbOkWSHL8+5Hih2VjP1qg2Dq7iKOE4zK/xonQUBQv4OO0GAJcmw4jFap7KXJ/zC4CdeeL4jEXcpmSN9O5uAQrU+6fGO5hjvqXeoIQq07Blz+7VzHPaBd91+vp7CJpi///znTRpVeRWchM5H8rkVe6IifjtpUpkc/+VrB3AHSw== X-YMail-OSG: JeLHoUIVM1m2g7xaLwg23hp.6MLc0lHclRJ_Hy.t6K0g8DcyejeQCk_YdjYT75X 2r3cFwvdWejeZSVBSsOIKjIkvsHP40bb4HKWNOwNlhk9ijFDgBoPHDxUqvkfg3MJDcDVXdkjLMQu P3zM444hXiTeZqoVgtXpo90A0O2otaM_6Jsm4F8xf6KGXOIfZX.mKDocXAsEh_HufPbz5BaBc_dL mERQsEBs7KOVGtMGcn5Vi8idvS_zNSCQVlzipO5NNsmhzgVuXU.0UAGkV7z5TZsi6N29_EKPsH_B R2UIriJQaJn3X7gHB8SiWL8Mr60xVufd6HYF2Hf0BfUn4wVp1a2a7iXGowMvCuwOejpUMF2ghVzw V7LTbxJAoW4gozgfY76LzmNCTWOvX35E1fIr3B1qHplojF42SIJSz7cjKUrpKKnuxx54nd.ZWPmH yCbPyzRuTwCIUIGiABZDXaFww.FExhKJ1CVfSWzSpirqpXIa20anZyg4utCbZ1pSWo0abGLtRLjx VDQXo7rsEEPk4nNUeLvUPwYIUJgZn.1WLu15x_0GBH6SsIMQI7XAz17mW89Av5LOnZoZ2etjQqA_ Bsf3owUFqO5VweJISVXHg0SW7gL_Exz66dvgsX4hf7esyuUBfIpexfZh2wEi2HVVyQ0Ki6A8rHj9 7GwEQy4RaU3cXwfB6z8.pRYFdq.A5rc6_j82k.MvPXA3xFKyCtj7F6zPVM_6LHU2CuvqD7fABpmg O4Qbw78nUOrU5gAYmpVBlLiskCC9JcQFHJsppMr6ikI2feXCI_n8NH2GF_NBDKDT0iP_Glzitp3j oIEPTZHXgmc6_hT0jVfyt1AhtBj.31fshNSiYDUM5_ X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Tue, 1 Mar 2022 00:40:23 +0000 Original-Received: by kubenode514.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 80a8ec2700486b710160bc72461f088c; Tue, 01 Mar 2022 00:40:17 +0000 (UTC) In-Reply-To: (martin rudalics's message of "Mon, 28 Feb 2022 16:50:29 +0100") X-Mailer: WebService/1.1.19797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.33; envelope-from=luangruo@yahoo.com; helo=sonic307-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286740 Archived-At: martin rudalics writes: > While we're there: If I'm not mistaken, xg_frame_set_char_size now has > three instances of > > #ifndef HAVE_PGTK > gtk_window_resize (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)), > outer_width, outer_height); > #else > if (FRAME_GTK_OUTER_WIDGET (f)) > { > gtk_window_resize (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)), > outer_width, outer_height); > } > else > { > gtk_widget_set_size_request (FRAME_GTK_WIDGET (f), > outer_width, outer_height); > } > #endif > > Could you please refactor these into a separate routine and/or at least > remove those extra braces. I'm not sure what those are for, but I will look into that. Thanks.