From: Po Lu <luangruo@yahoo.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Po Lu via Mailing list for Emacs changes <emacs-devel@gnu.org>
Subject: Re: master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change.
Date: Sun, 31 Jul 2022 15:26:15 +0800 [thread overview]
Message-ID: <87zggphhew.fsf@yahoo.com> (raw)
In-Reply-To: <87r1214vi3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 31 Jul 2022 09:00:20 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> With these scroll bar changes (probably), I'm getting the following
>> warning in a Gtk build:
>>
>> xterm.c: In function 'XTset_vertical_scroll_bar':
>> xterm.c:14936:7: warning: implicit declaration of function
>> 'x_scroll_bar_redraw'; did you mean 'x_scroll_bar_remove'?
>> [-Wimplicit-function-declaration]
>> 14936 | x_scroll_bar_redraw (bar);
>> | ^~~~~~~~~~~~~~~~~~~
>> | x_scroll_bar_remove
>> xterm.c:14936:7: warning: nested extern declaration of
>> 'x_scroll_bar_redraw' [-Wnested-externs]
>
> And:
>
> /usr/bin/ld: xterm.o: in function `XTset_vertical_scroll_bar':
> /home/larsi/src/emacs/trunk/src/xterm.c:14936: undefined reference to `x_scroll_bar_redraw'
> collect2: error: ld returned 1 exit status
Should be fixed now, thanks. Could you (and others) also run a build
with --without-toolkit-scroll-bars for a while, and see if any visual
glitches come up in the scroll bars?
Thanks.
next prev parent reply other threads:[~2022-07-31 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165923547930.6475.9574531983497191865@vcs2.savannah.gnu.org>
[not found] ` <20220731024440.07F9EC09BFB@vcs2.savannah.gnu.org>
2022-07-31 6:57 ` master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change Lars Ingebrigtsen
2022-07-31 7:00 ` Lars Ingebrigtsen
2022-07-31 7:26 ` Po Lu [this message]
2022-07-31 8:36 ` Lars Ingebrigtsen
2022-07-31 8:45 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zggphhew.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).