From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master b7f227ed8b 2/2: ; * src/xterm.c (XTset_vertical_scroll_bar): Fix typo in last change. Date: Sun, 31 Jul 2022 15:26:15 +0800 Message-ID: <87zggphhew.fsf@yahoo.com> References: <165923547930.6475.9574531983497191865@vcs2.savannah.gnu.org> <20220731024440.07F9EC09BFB@vcs2.savannah.gnu.org> <87v8rd4vn0.fsf@gnus.org> <87r1214vi3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20860"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Po Lu via Mailing list for Emacs changes To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 31 09:28:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oI3NG-0005HT-Kj for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 09:28:30 +0200 Original-Received: from localhost ([::1]:53708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oI3NF-0004Ut-E1 for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 03:28:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI3LJ-0003Kj-CD for emacs-devel@gnu.org; Sun, 31 Jul 2022 03:26:29 -0400 Original-Received: from sonic302-20.consmr.mail.ne1.yahoo.com ([66.163.186.146]:40342) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oI3LH-0007jL-SV for emacs-devel@gnu.org; Sun, 31 Jul 2022 03:26:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1659252385; bh=VfeP9xFxqh8Co5EnSQG8iSCyD5u1sUKmHeEQTlab9RE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=lsPS1e+52Hrifi8dMva5ysNCYuy6pimYtAlFO99hNO8o9Ada66sO+jclNxVwc2AKsGjbh6hh05+xXdZz20NbXm429tRnTr1wO3I+pxc5acIC7zawSklvr15DDFzSWT6x34IfpWpHpOPIUbPTCmRHI3kB1J0wJdgWAtPkqNCSHkQOADTc3iXfusB8gcB+VCOtlNwzcIECkGd1rBjumz0qybkbUCwKr2t9LEZdS9LLIDwciW35JCmCFTrP6tb/u2RjI5PRBiUnjqfAt2xb2wTHWwUKwZCGmarH3VlR5OZBfJueKICc3FKpInb9ckkRK1bqn2/yWzPlbkMpA3JACoYNTA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1659252385; bh=JnWr7XqVLz8552nea5/vbCIg6O2O4sT517wWOnwJzoS=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=BFsM6pQzRE4wbREGOcrH/r2oBf1UDTtwZlSGoIwE0HtvkEPQi49kj+RHHUPw1TPWuIGh54erKodHr+8CIqPjFjCYErPALcJu9NYVhzD8jKowOlOm8yRMPYrY3QuiZ1ZWVkdpiOIyMk7I9uK/ae96qlwPBYKmQ8/+PXAFnY0kxDSjW8640x6S5qpHi85c1w4umxljBVYSRe0q2HiW/o03TLYfAqppaVun55wuf90TQxgzf7Tk8aIHSY+GIcrgWyI8qLagdBg1QyL6PwuKoU7f8TfGy/J1fAGbl3NKV9MDZU34Lm/Xwx6k9ckGra/KctaKnw6dYJSe/zo4n4MJKV+z6g== X-YMail-OSG: sysKEo4VM1k6TH0FPSiN5YtijNXL_tmYrVxYmowcIa9FOCy1b9rjsW5GkTSjSFB CMp3M__e0t4VSpIrRaUdi_4XhY1Iy.oplQkHiDxqtLeKc3G8oWV4aenisd0XbAsYn8t0Jn.7c1S8 JumUj4hQekmhhJ_OHwhIUZWNIIl1AukjM.caLWyDVeQOjq_Q7hxqQX6Mrje3lfL3XAlWoMcaLB5q G5Pnic3AKyfhZ8DrVixiTPGcShO9euKypQEiMCKCHmYG4A5O768dKTztaaZY1PW.qYZbwxh116.. 9pdNifyxQ9yc4.4R.__c1XbOA4ekRnXTQb_2zBmat0Fl1_ADk4Jap3f.V3WNr38v9rHod2qYT3pA DSc94mtnOQ2cZ0mbphlHVLVP4k06DXXruNzKi.Wr92ARrjJef5jkGMJrxCzjBZN_yObEKAzlYUTo _2S63Rk56XRMjlx6mX90qYfQjeoDP1tEwWbBLIa4WLL03rGVCr9tm5eWrdg5Vbaj2A26a3Lbxf4y n_SMqhZbv27q2BjaGj0.EHbvVA8ipE_GB9e1ey7TRGdG5uVWNLTGkNjJiDxkG7mRFd1ghN2zvaNa i7NqgECHgur7YnQ4.S4Rh8qCCzMisew2wFrUHwy4WIqUNHUk0mLlm9fQLDi.K0jrF_QlXpMHvUy1 ob3hxDm61H0.jtgDTx0gm3USih52FUM72Wv_ipY.Tlq4Xq9XtG_H3U13zpOhNibrKFn87kjoWYd_ ixpcrnad5uRFrIK.bIdNhzM3wbQT0SI9hk884K5ZMGsV4Mbk7x2nIBjgXqaMDvQ.rXJDtfR4o64t xsqg4D8kdE.JPD0ImxkKjf.cXaKS27v6J_rNJVsJ2k X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Sun, 31 Jul 2022 07:26:25 +0000 Original-Received: by hermes--canary-production-sg3-854c886654-8kdzs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8cb9c7ad3c5cec9f8168f201979c1436; Sun, 31 Jul 2022 07:26:20 +0000 (UTC) In-Reply-To: <87r1214vi3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 31 Jul 2022 09:00:20 +0200") X-Mailer: WebService/1.1.20447 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.146; envelope-from=luangruo@yahoo.com; helo=sonic302-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292899 Archived-At: Lars Ingebrigtsen writes: > Lars Ingebrigtsen writes: > >> With these scroll bar changes (probably), I'm getting the following >> warning in a Gtk build: >> >> xterm.c: In function 'XTset_vertical_scroll_bar': >> xterm.c:14936:7: warning: implicit declaration of function >> 'x_scroll_bar_redraw'; did you mean 'x_scroll_bar_remove'? >> [-Wimplicit-function-declaration] >> 14936 | x_scroll_bar_redraw (bar); >> | ^~~~~~~~~~~~~~~~~~~ >> | x_scroll_bar_remove >> xterm.c:14936:7: warning: nested extern declaration of >> 'x_scroll_bar_redraw' [-Wnested-externs] > > And: > > /usr/bin/ld: xterm.o: in function `XTset_vertical_scroll_bar': > /home/larsi/src/emacs/trunk/src/xterm.c:14936: undefined reference to `x_scroll_bar_redraw' > collect2: error: ld returned 1 exit status Should be fixed now, thanks. Could you (and others) also run a build with --without-toolkit-scroll-bars for a while, and see if any visual glitches come up in the scroll bars? Thanks.