unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Richard Stallman <rms@gnu.org>
Cc: jporterbugs@gmail.com,  emacs-devel@gnu.org
Subject: Re: [GNU ELPA] New package: Urgrep
Date: Thu, 18 May 2023 13:23:18 +0000	[thread overview]
Message-ID: <87zg61n589.fsf@posteo.net> (raw)
In-Reply-To: <E1pzPck-0003Ru-S8@fencepost.gnu.org> (Richard Stallman's message of "Wed, 17 May 2023 18:27:58 -0400")

Richard Stallman <rms@gnu.org> writes:

> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
>   > Since this is just an brief, internal comment in elpa-admin.el, I
>   > wouldn't be that concerned.  I believe it is justified to assume that
>   > everyone working on the script knows what this means.
>
> It is not unusual for people who don't kow the internals of a program
> to read its code to learn to understand it.  So how about changing
> those lines to make that learning easier?  Please give future
> maintainers a break!

I started working on ELPA about two years ago, and comments like these
were never an issue.  Of course in this individual case it can be
changed, but generally speaking I would consider the ability to
understand what a comment like this means a pre-requisite for being able
to hack on a file like elpa-admin.el, as it "proves" familiarity with
Elisp packaging and conventions around Emacs packages.

Or perhaps I am misunderstanding you, what exactly do you find confusing
about comments like these in general? 

-- 
Philip Kaludercic



  reply	other threads:[~2023-05-18 13:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  5:18 [GNU ELPA] New package: Urgrep Jim Porter
2023-05-09  8:45 ` Philip Kaludercic
2023-05-09 20:26   ` Jim Porter
2023-05-10  6:22     ` Philip Kaludercic
2023-05-10 16:22       ` Jim Porter
2023-05-10 17:30         ` Philip Kaludercic
2023-05-12 21:52           ` Richard Stallman
2023-05-12 21:59             ` Jim Porter
2023-05-13  7:09               ` Philip Kaludercic
2023-05-15 22:13               ` Richard Stallman
2023-05-16  6:29                 ` Philip Kaludercic
2023-05-17 22:27                   ` Richard Stallman
2023-05-18 13:23                     ` Philip Kaludercic [this message]
2023-05-21 21:04                       ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg61n589.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).