unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master c122cc83186: Some minor Tramp changes
       [not found] ` <20230827083853.1B4B1C04582@vcs2.savannah.gnu.org>
@ 2023-09-02  8:23   ` Stefan Kangas
  2023-09-02 11:18     ` Michael Albinus
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Kangas @ 2023-09-02  8:23 UTC (permalink / raw)
  To: emacs-devel, Michael Albinus

Michael Albinus <Michael.Albinus@gmx.de> writes:

> branch: master
> commit c122cc831869a9a11f50187c5cf999389b223eee
> Author: Michael Albinus <michael.albinus@gmx.de>
> Commit: Michael Albinus <michael.albinus@gmx.de>
>
>     Some minor Tramp changes
>
>     * lisp/net/tramp-adb.el (tramp-adb-handle-make-process):
>     Fix error message.
>
>     * lisp/net/tramp-cache.el (tramp-dump-connection-properties):
>     Remove `tramp-null-hop'.
>
>     * lisp/net/tramp-message.el (tramp-message, tramp-backtrace)
>     (tramp-error): Handle VEC being nil.
>
>     * lisp/net/tramp.el (tramp-null-hop): Add ;;;###tramp-autoload cookie.
>     Use pseudo method "local".
>     (tramp-file-name-unify): IF VEC is nil, set it to `tramp-null-hop'.
>     (tramp-set-completion-function): Support also functions with
>     METHOD as argument.
>     (tramp-get-completion-methods): Add argument HOP.

This change breaks ivy, as it depends on it being callable as:

    (tramp-get-completion-methods "")

This now gives

    (wrong-number-of-arguments (2 . 2) 1)

How about making the new HOP argument optional?



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master c122cc83186: Some minor Tramp changes
  2023-09-02  8:23   ` master c122cc83186: Some minor Tramp changes Stefan Kangas
@ 2023-09-02 11:18     ` Michael Albinus
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Albinus @ 2023-09-02 11:18 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

Stefan Kangas <stefankangas@gmail.com> writes:

Hi Stefan,

> This change breaks ivy, as it depends on it being callable as:
>
>     (tramp-get-completion-methods "")
>
> This now gives
>
>     (wrong-number-of-arguments (2 . 2) 1)
>
> How about making the new HOP argument optional?

Done, pushed to master.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-02 11:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <169312553277.14232.3717064903097285333@vcs2.savannah.gnu.org>
     [not found] ` <20230827083853.1B4B1C04582@vcs2.savannah.gnu.org>
2023-09-02  8:23   ` master c122cc83186: Some minor Tramp changes Stefan Kangas
2023-09-02 11:18     ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).