From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 63f4f02: If requested, use external image converters for exotic formats
Date: Mon, 30 Sep 2019 06:16:34 +0200 [thread overview]
Message-ID: <87y2y68llp.fsf@gnus.org> (raw)
In-Reply-To: <jwvmuen2qkf.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 29 Sep 2019 09:22:12 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Why not split the string directly in image-converter--converters?
> Same for the ":probe" part?
>
> I.e. use something like:
>
> (defvar image-converter--converters
> '((graphicsmagick :command "gm" :convertargs ("convert") :probe ("-list" "format"))
> (imagemagick :command "convert" :probe ("-list" "format"))
> (ffmpeg :command "ffmpeg" :probe "-decoders"))
>
> so it works even if the command's name (or some of the args your need to
> pass to the command) contains spaces?
Yup; I'll do that.
> This said, given that you use separate methods for the different backends:
>
> (cl-defmethod image-converter--probe ((type (eql imagemagick)))
>
> I don't understand why you need those args in
> image-converter--converters instead of putting them directly into
> their respective methods.
Two reasons: I wanted to give the users some more customisability, and
reuse the same code in both the ImageMagick and GraphicsMagick
conversion functions.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-09-30 4:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190928232618.29254.42705@vcs0.savannah.gnu.org>
[not found] ` <20190928232619.9AF492068F@vcs0.savannah.gnu.org>
2019-09-29 13:22 ` [Emacs-diffs] master 63f4f02: If requested, use external image converters for exotic formats Stefan Monnier
2019-09-30 4:16 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2y68llp.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).