From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 63f4f02: If requested, use external image converters for exotic formats Date: Mon, 30 Sep 2019 06:16:34 +0200 Message-ID: <87y2y68llp.fsf@gnus.org> References: <20190928232618.29254.42705@vcs0.savannah.gnu.org> <20190928232619.9AF492068F@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250368"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 30 06:17:27 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEn7l-0012xL-7k for ged-emacs-devel@m.gmane.org; Mon, 30 Sep 2019 06:17:25 +0200 Original-Received: from localhost ([::1]:43542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEn7i-0003hQ-TT for ged-emacs-devel@m.gmane.org; Mon, 30 Sep 2019 00:17:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44756) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEn73-0003RE-7F for emacs-devel@gnu.org; Mon, 30 Sep 2019 00:16:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEn71-0002dO-Ij for emacs-devel@gnu.org; Mon, 30 Sep 2019 00:16:40 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36720) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iEn71-0002c8-22 for emacs-devel@gnu.org; Mon, 30 Sep 2019 00:16:39 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEn6w-0002U3-VE; Mon, 30 Sep 2019 06:16:37 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 29 Sep 2019 09:22:12 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240403 Archived-At: Stefan Monnier writes: > Why not split the string directly in image-converter--converters? > Same for the ":probe" part? > > I.e. use something like: > > (defvar image-converter--converters > '((graphicsmagick :command "gm" :convertargs ("convert") :probe ("-list" "format")) > (imagemagick :command "convert" :probe ("-list" "format")) > (ffmpeg :command "ffmpeg" :probe "-decoders")) > > so it works even if the command's name (or some of the args your need to > pass to the command) contains spaces? Yup; I'll do that. > This said, given that you use separate methods for the different backends: > > (cl-defmethod image-converter--probe ((type (eql imagemagick))) > > I don't understand why you need those args in > image-converter--converters instead of putting them directly into > their respective methods. Two reasons: I wanted to give the users some more customisability, and reuse the same code in both the ImageMagick and GraphicsMagick conversion functions. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no