From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: john muhl <jm@pub.pink>
Cc: emacs-devel@gnu.org
Subject: Re: master 8d4a8b7dfd0: ; Re-apply accidentally reverted commit
Date: Tue, 19 Mar 2024 22:27:55 +0100 [thread overview]
Message-ID: <87y1adap44.fsf@gmail.com> (raw)
In-Reply-To: <87y1afkn5v.fsf@pub.pink> (john muhl's message of "Mon, 18 Mar 2024 20:46:57 -0500")
john muhl <jm@pub.pink> writes:
> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
>> john muhl <jm@pub.pink> writes:
>>
>>> The test you added here fails when run by a user that doesn’t have
>>> Git configured. When run by such a user the ‘git commit -mFirst’
>>> command errors which causes the test to fail:
>>>
>>> $ git commit -mFirst
>>> Author identity unknown
>>>
>>> *** Please tell me who you are.
>>
>> I can reproduce the failure running 'EMAIL= make test' (since EMAIL is
>> how I let Git know about my email, rather than ~/.gitconfig:user.email).
>> The attached patch lets the test pass; let me know if it looks sensible?
>> I'll install it then.
>>
>> [2. text/x-patch; 0001-Fix-vc-git-test-when-no-identities-are-configured.patch]...
>
> Thanks the test passes here too.
Smashing, thanks for the confirmation 👌 Pushed!
prev parent reply other threads:[~2024-03-19 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171071192781.29642.16850908468499185478@vcs2.savannah.gnu.org>
[not found] ` <20240317214528.4FA50C1CB35@vcs2.savannah.gnu.org>
2024-03-18 0:50 ` master 8d4a8b7dfd0: ; Re-apply accidentally reverted commit john muhl
2024-03-18 7:31 ` Kévin Le Gouguec
2024-03-18 19:02 ` Kévin Le Gouguec
2024-03-19 1:46 ` john muhl
2024-03-19 21:27 ` Kévin Le Gouguec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1adap44.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jm@pub.pink \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).