From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.devel Subject: Re: master 8d4a8b7dfd0: ; Re-apply accidentally reverted commit Date: Tue, 19 Mar 2024 22:27:55 +0100 Message-ID: <87y1adap44.fsf@gmail.com> References: <171071192781.29642.16850908468499185478@vcs2.savannah.gnu.org> <20240317214528.4FA50C1CB35@vcs2.savannah.gnu.org> <87zfuwpapo.fsf@pub.pink> <87plvrcqj5.fsf@gmail.com> <87y1afkn5v.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21611"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: john muhl Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 19 22:28:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmh0m-0005QH-Q8 for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Mar 2024 22:28:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmh08-0000Fc-De; Tue, 19 Mar 2024 17:28:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmh07-0000F9-0P for emacs-devel@gnu.org; Tue, 19 Mar 2024 17:28:03 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmh05-0001wU-Cz for emacs-devel@gnu.org; Tue, 19 Mar 2024 17:28:02 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-41467d697a2so6053335e9.1 for ; Tue, 19 Mar 2024 14:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710883677; x=1711488477; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6nNv+yoXy/vWpriBxRhHJYK93bXGsZJDE4/OG9n+32E=; b=Vaxc4bmMcvKvtAnM2A0hX/tiOn/Mgz5TzjuexTjZPFsCsNw1Ihoiib01NRgNr40+UA 1EczbG7m2mgBz1CD84XdwDIxBTRP5G2AxHJrflbl+Av+P4KvNT1HlHQnhqDYuHQgQ280 0khzJIIkR6XUKec9ziQzIj65X1ijrUijbf20f/mEiCl1LMW8fl46MWZudrox5MPw8Lia VnvM0Kpl1m6cwXKBnqxgzs3Apw3uTFVxl9QtoRTz5el3bDb55xPrqEPggAMyTdy80RVv O4cl9WFy8vHOXSSpBuOb7/a+cADov2wXa18PxsAHxK3DXkysnTFtfLhvU3pZ0mlmK9/5 6AdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710883677; x=1711488477; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6nNv+yoXy/vWpriBxRhHJYK93bXGsZJDE4/OG9n+32E=; b=gCGxXld4RcVB8ZeEbOwUEehUEEe2J+PS068sIejg8C5wmFBg8C7BKTT/lQzE2DL9kG YJrcZqk9kMfPwzfNnnH461QcEcofaG5+2G2/9tclHmGWEYTtI67uCrts/uoeyM3j5T4E x+Q6YLuAFJ2tyIXoou0OEPYdKKg3OYUUP96Xvhu4qj1CeRDw4yen4egSQnU0oSTLV/sg NIH+1pI6K/5GMZTUyBmntCfOOijbs82/GFDjvECAFSZwbc84UyxGxCQP0mkGGLRV79Qm hjOx6szM8Rs+vQ2s8CkX8N6quyZ/1VmJfQ6FXu4sgcZ26ratf/eTyWo//tX2ls4EXKsO nggA== X-Gm-Message-State: AOJu0YzJwSk3KuRj4MC1/N9z2RAj4bktEA4OQicGHBmZXTW5KnItskFM ZA2rjYhZhW+He8MDpEwDGXeD5Ufy/Iz3VQmB5ct42t+BWiB3Vt1wMiXNmJuf X-Google-Smtp-Source: AGHT+IE4Se757LPUOoQp8iVCJJDkeo1YvFKZZ87PFQoNvkSbbDalPz/SzqLzQS0wbRHNoOKFkKs2Rw== X-Received: by 2002:adf:f003:0:b0:33d:d15b:9789 with SMTP id j3-20020adff003000000b0033dd15b9789mr11380794wro.65.1710883677060; Tue, 19 Mar 2024 14:27:57 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id bo6-20020a056000068600b003418016b04csm4391366wrb.76.2024.03.19.14.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 14:27:56 -0700 (PDT) In-Reply-To: <87y1afkn5v.fsf@pub.pink> (john muhl's message of "Mon, 18 Mar 2024 20:46:57 -0500") Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317202 Archived-At: john muhl writes: > K=C3=A9vin Le Gouguec writes: > >> john muhl writes: >> >>> The test you added here fails when run by a user that doesn=E2=80=99t h= ave >>> Git configured. When run by such a user the =E2=80=98git commit -mFirst= =E2=80=99 >>> command errors which causes the test to fail: >>> >>> $ git commit -mFirst >>> Author identity unknown >>> >>> *** Please tell me who you are. >> >> I can reproduce the failure running 'EMAIL=3D make test' (since EMAIL is >> how I let Git know about my email, rather than ~/.gitconfig:user.email). >> The attached patch lets the test pass; let me know if it looks sensible? >> I'll install it then. >> >> [2. text/x-patch; 0001-Fix-vc-git-test-when-no-identities-are-configured= .patch]... > > Thanks the test passes here too. Smashing, thanks for the confirmation =F0=9F=91=8C Pushed!