unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] Bug in package.el refuses emacs to load
@ 2010-09-04  5:01 Noorul Islam K M
  2010-09-04 17:55 ` Chong Yidong
  0 siblings, 1 reply; 4+ messages in thread
From: Noorul Islam K M @ 2010-09-04  5:01 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]


I seems to have 'nil' as one of the members of the list
'load-path'. Being this the case package.el breaks while defining a
custom variable. Attached is the patch for this.

package.el: Fix to check 'nil' member in load-path.

* lisp/emacs-lisp/package.el (package-directory-list) : Ignore 'nil'
member from load-path if exists.

Thanks and Regards
Noorul


[-- Attachment #2: package.el.txt --]
[-- Type: text/plain, Size: 881 bytes --]

=== modified file 'lisp/emacs-lisp/package.el'
*** lisp/emacs-lisp/package.el	2010-08-26 03:31:34 +0000
--- lisp/emacs-lisp/package.el	2010-09-04 04:35:36 +0000
*************** packages in `package-directory-list'."
*** 260,266 ****
    ;; Defaults are subdirs named "elpa" in the site-lisp dirs.
    (let (result)
      (dolist (f load-path)
!       (if (equal (file-name-nondirectory f) "site-lisp")
  	  (push (expand-file-name "elpa" f) result)))
      (nreverse result))
    "List of additional directories containing Emacs Lisp packages.
--- 260,266 ----
    ;; Defaults are subdirs named "elpa" in the site-lisp dirs.
    (let (result)
      (dolist (f load-path)
!       (if (and f (equal (file-name-nondirectory f) "site-lisp"))
  	  (push (expand-file-name "elpa" f) result)))
      (nreverse result))
    "List of additional directories containing Emacs Lisp packages.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bug in package.el refuses emacs to load
  2010-09-04  5:01 [PATCH] Bug in package.el refuses emacs to load Noorul Islam K M
@ 2010-09-04 17:55 ` Chong Yidong
  2010-09-05  4:59   ` Ted Zlatanov
  0 siblings, 1 reply; 4+ messages in thread
From: Chong Yidong @ 2010-09-04 17:55 UTC (permalink / raw)
  To: Noorul Islam K M; +Cc: emacs-devel

Noorul Islam K M <noorul@noorul.com> writes:

> I seems to have 'nil' as one of the members of the list
> 'load-path'. Being this the case package.el breaks while defining a
> custom variable. Attached is the patch for this.

Thanks, applied.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bug in package.el refuses emacs to load
  2010-09-04 17:55 ` Chong Yidong
@ 2010-09-05  4:59   ` Ted Zlatanov
  2010-09-05  6:23     ` Chong Yidong
  0 siblings, 1 reply; 4+ messages in thread
From: Ted Zlatanov @ 2010-09-05  4:59 UTC (permalink / raw)
  To: emacs-devel

On Sat, 04 Sep 2010 13:55:17 -0400 Chong Yidong <cyd@stupidchicken.com> wrote: 

CY> Noorul Islam K M <noorul@noorul.com> writes:
>> I seems to have 'nil' as one of the members of the list
>> 'load-path'. Being this the case package.el breaks while defining a
>> custom variable. Attached is the patch for this.

CY> Thanks, applied.

Isn't that indicating another problem in the user setup?  I think it's
better to issue a message than to just ignore nil paths.

Ted




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bug in package.el refuses emacs to load
  2010-09-05  4:59   ` Ted Zlatanov
@ 2010-09-05  6:23     ` Chong Yidong
  0 siblings, 0 replies; 4+ messages in thread
From: Chong Yidong @ 2010-09-05  6:23 UTC (permalink / raw)
  To: Ted Zlatanov; +Cc: emacs-devel

Ted Zlatanov <tzz@lifelogs.com> writes:

>>> I seems to have 'nil' as one of the members of the list
>>> 'load-path'. Being this the case package.el breaks while defining a
>>> custom variable. Attached is the patch for this.
>
> CY> Thanks, applied.
>
> Isn't that indicating another problem in the user setup?  I think it's
> better to issue a message than to just ignore nil paths.

No, load-path allows nil; that means the default directory.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-09-05  6:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-04  5:01 [PATCH] Bug in package.el refuses emacs to load Noorul Islam K M
2010-09-04 17:55 ` Chong Yidong
2010-09-05  4:59   ` Ted Zlatanov
2010-09-05  6:23     ` Chong Yidong

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).