From: "João Távora" <joaotavora@gmail.com>
To: emacs-devel@gnu.org
Cc: Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: master 5044c19 2/2: project.el: A project has only one main root now
Date: Mon, 25 May 2020 18:17:39 +0100 [thread overview]
Message-ID: <87wo50szm4.fsf@gmail.com> (raw)
In-Reply-To: <20200523015942.848612043D@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Fri, 22 May 2020 21:59:42 -0400 (EDT)")
dgutov@yandex.ru (Dmitry Gutov) writes:
> branch: master
> commit 5044c19001fe608f2eac621add2e05cbca6c804b
> Author: Dmitry Gutov <dgutov@yandex.ru>
> Commit: Dmitry Gutov <dgutov@yandex.ru>
>
> project.el: A project has only one main root now
>
> Practice shows that the vast majority of projects only use one main
> root. The users of this API very often make this assumption as well.
> The rest of the "roots" should be possible to express through
> project-external-roots.
I welcome this change, it makes perfect sense and simplifies a bit of of
Eglot. So thanks!
However, it is breaking Eglot's tests. Why? Well Eglot runs its tests
against master and has recently decided to make every warning a test
failure (and project-roots is an obsoleted variable).
Perhaps Eglot should do neighter of those things, but perhaps if you
bumped the version in project.el to 0.3.0 then Eglot could just start
relying on that. Or aren't you confident enough in this new API?
João
next parent reply other threads:[~2020-05-25 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200523015940.19021.91647@vcs0.savannah.gnu.org>
[not found] ` <20200523015942.848612043D@vcs0.savannah.gnu.org>
2020-05-25 17:17 ` João Távora [this message]
2020-05-25 19:06 ` master 5044c19 2/2: project.el: A project has only one main root now Dmitry Gutov
2020-05-25 19:52 ` João Távora
2020-05-25 20:00 ` Dmitry Gutov
2020-05-25 20:24 ` João Távora
2020-05-25 21:52 ` Dmitry Gutov
2020-05-25 22:01 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo50szm4.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).