From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master 5044c19 2/2: project.el: A project has only one main root now Date: Mon, 25 May 2020 18:17:39 +0100 Message-ID: <87wo50szm4.fsf@gmail.com> References: <20200523015940.19021.91647@vcs0.savannah.gnu.org> <20200523015942.848612043D@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="46951"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 25 19:18:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdGk8-000C5B-3A for ged-emacs-devel@m.gmane-mx.org; Mon, 25 May 2020 19:18:28 +0200 Original-Received: from localhost ([::1]:37190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdGk7-0005vZ-5E for ged-emacs-devel@m.gmane-mx.org; Mon, 25 May 2020 13:18:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdGjP-0005SL-Jb for emacs-devel@gnu.org; Mon, 25 May 2020 13:17:43 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:46676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdGjO-0007oU-Ns for emacs-devel@gnu.org; Mon, 25 May 2020 13:17:43 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id x6so4092601wrm.13 for ; Mon, 25 May 2020 10:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=dG2vCTC2/M3CYW2tckkNfPyDTKIcRHJ8HBM49VCvuak=; b=HvSpuDs2su3l/HoHeHv+PSeg8qb5hrbRG7i85mABwtNoWuF4jX4JZcO8sgmaTAHD9M gXGgEqP28SawModmIcIgAwfcQJXA8G7vsO9lQngyymcb+ST4kw1kZnn51Q9OYBXnHC+h RYcOeXxM1wD5zx0WAD9lqgBuUgcp7J7FdjBzqQ/K/U3vw9KRRuGMKXnAcVmPuSOzjUHl BFxGvvgQpilgW7cYFTL8dYgr+BP4tCm1eA8Qo411E+RXXxe8WrsTaoPYTv3JMvzdl77S gkkn2CtapjaoIbkz/p5fZuIVp5XpzcSRaZQaNWu88jwW6Sq6iz8wbe5/iW3jTcIXczCA Mj0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=dG2vCTC2/M3CYW2tckkNfPyDTKIcRHJ8HBM49VCvuak=; b=feEHJS1Nw7JtqcE6/kHpzWYnKq7tTbIcO5qZkjGInyTvBmswHmVhgifqeXrFzTdbCz QdsWWySgvKN/n++MBH/PvEA82VLmHtiLWqEDyzxLR/E9DSLr8sQPHXvnh4GuG6f2h/VI Nd1pXUOJMGjDMvW+kwVDEdwJk8iiOgC8fwaj+XvPZY8BmxWUzo6Iii0qxfCCgTxGm9at 0niIVW0Voxjb1gDjbHCo49euY1x9GvouiKaN9yc/Mt03ffvZpWDM4Y4nAwKwuLWorEY8 NB7OKDKGvcLIhNrM6UhLSy/j/+ZS2dFlvHbVOZSlR5/nR+8HdQVrEJ5+ke3Gds9Kytb2 B6Bg== X-Gm-Message-State: AOAM530p5pxGU5GLpUtTXmXTL6UOovxzEjMCvKnBgeuAvLgyEjiOlWg6 nCQ2yvLxqFF9zCfLt1D6JhE= X-Google-Smtp-Source: ABdhPJyxGu5OKxh6x2vsCmemBcZYHLyALtBJ3zK2JZSUno0V2YnPkfL4lA4nqOktoCEGchpkzTwJ9w== X-Received: by 2002:a05:6000:ce:: with SMTP id q14mr17569330wrx.105.1590427061282; Mon, 25 May 2020 10:17:41 -0700 (PDT) Original-Received: from krug ([89.180.145.189]) by smtp.gmail.com with ESMTPSA id g82sm2352201wmf.1.2020.05.25.10.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2020 10:17:40 -0700 (PDT) In-Reply-To: <20200523015942.848612043D@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Fri, 22 May 2020 21:59:42 -0400 (EDT)") Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x42b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: -0.1 X-Spam_bar: / X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251376 Archived-At: dgutov@yandex.ru (Dmitry Gutov) writes: > branch: master > commit 5044c19001fe608f2eac621add2e05cbca6c804b > Author: Dmitry Gutov > Commit: Dmitry Gutov > > project.el: A project has only one main root now >=20=20=20=20=20 > Practice shows that the vast majority of projects only use one main > root. The users of this API very often make this assumption as well. > The rest of the "roots" should be possible to express through > project-external-roots. I welcome this change, it makes perfect sense and simplifies a bit of of Eglot. So thanks! However, it is breaking Eglot's tests. Why? Well Eglot runs its tests against master and has recently decided to make every warning a test failure (and project-roots is an obsoleted variable). Perhaps Eglot should do neighter of those things, but perhaps if you bumped the version in project.el to 0.3.0 then Eglot could just start relying on that. Or aren't you confident enough in this new API? Jo=C3=A3o