[NonGNU ELPA] New package proposal: git-modes

[NonGNU ELPA] New package proposal: git-modes

[Jonas Bernoulli]

Hello,

I would like to propose the addition of "git-modes" to NonGNU Elpa.  It
provides three simple major-modes gitattributes-mode, gitconfig-mode and
gitignore-mode.

These modes/libraries used to be (and still are) distributes as three
separate packages on Melpa but I think it would be best to distribute
them as a single package.  I've asked Steve Purcell (Melpa maintainer)
about it and he agrees.  The three existing packages will be replaced
with the "git-modes" packages on Melpa.

A "git-modes.el" library that merely loads the other libraries existed
for a long time already.  Users don't actually have to load that, or
the individual libraries for that matter, because autoloading adds the
appropriate entries to auto-mode-alist.

Adding to GNU ELPA is not an option because one of the main authors
is against assigning copyright to the FSF as a matter of principle.

"git-modes" can be found at https://github.com/magit/git-modes.  You
can git-clone from that URL to avoid non-free javascript.  Note that
I am preparing for the addition to NonGNU ELPA on the "next" branch.

     Cheers,
     Jonas

Re: [NonGNU ELPA] New package proposal: git-modes

[Stefan Monnier]

> I would like to propose the addition of "git-modes" to NonGNU Elpa.  It
> provides three simple major-modes gitattributes-mode, gitconfig-mode and
> gitignore-mode.

Sounds good to me.  Let me know if you need help adding it.


        Stefan

Re: [NonGNU ELPA] New package proposal: git-modes

[Philip Kaludercic]

Jonas Bernoulli <jonas@bernoul.li> writes:

> Hello,

Hi!

> "git-modes" can be found at https://github.com/magit/git-modes.  You
> can git-clone from that URL to avoid non-free javascript.  Note that
> I am preparing for the addition to NonGNU ELPA on the "next" branch.

I seem to see no "next" branch in the repository at the moment (neither
on GitHub nor in my local checkout).

        $ git branch -al
        * master
          remotes/origin/HEAD -> origin/master
          remotes/origin/master

Also, do you plan to continue the development on the next branch (so
that the MELPA and the NonGNU ELPA version are maintained in parallel),
or will you merge the NonGNU ELPA version back into the master branch
later on?

-- 
	Philip Kaludercic

Re: [NonGNU ELPA] New package proposal: git-modes

[Jonas Bernoulli]

> I seem to see no "next" branch in the repository at the moment (neither
> on GitHub nor in my local checkout).

I forgot to push.

> Also, do you plan to continue the development on the next branch

No, there is only one long lived branch "master", at least that's the
plan right now.  I probably shouldn't have named the temporary branch
"next" as that indeed is usually used for long-lived branches.

Re: [NonGNU ELPA] New package proposal: git-modes

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I would like to propose the addition of "git-modes" to NonGNU Elpa.  It
  > provides three simple major-modes gitattributes-mode, gitconfig-mode and
  > gitignore-mode.

Assuming these are worth distributing (I have no opinion on that),
should these be part of Emacs?  Can we get papers for them?

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: [NonGNU ELPA] New package proposal: git-modes

[Stefan Kangas]

Richard Stallman <rms@gnu.org> writes:

> Assuming these are worth distributing (I have no opinion on that),
> should these be part of Emacs?  Can we get papers for them?

IMO, it's a no-brainer that we would want them as part of Emacs.

Git is the most commonly used VCS in free software there these days, so
we need excellent support for it.  This includes merely "nice" things
such as syntax highlighting for its configuration files.

Re: git-modes

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

It sounds like these would not be a lot of work to write from scratch.
We can write a program like git-modes on our own from scratch.
Let's do that, and eliminate the obstacle.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: [NonGNU ELPA] New package proposal: git-modes

[Philip Kaludercic]

Richard Stallman <rms@gnu.org> writes:

> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
>   > I would like to propose the addition of "git-modes" to NonGNU Elpa.  It
>   > provides three simple major-modes gitattributes-mode, gitconfig-mode and
>   > gitignore-mode.
>
> Assuming these are worth distributing (I have no opinion on that),
> should these be part of Emacs?  Can we get papers for them?

Seems like it sadly isn't possible, as Jonas says:

> Adding to GNU ELPA is not an option because one of the main authors is
> against assigning copyright to the FSF as a matter of principle.

-- 
	Philip Kaludercic

Re: [NonGNU ELPA] New package proposal: git-modes

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Seems like it sadly isn't possible, as Jonas says:

  > > Adding to GNU ELPA is not an option because one of the main authors is
  > > against assigning copyright to the FSF as a matter of principle.

That's a shame.  But how big is per code?
Would it be feasible to write new code to replace that code?
-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: [NonGNU ELPA] New package proposal: git-modes

[Jonas Bernoulli]

Richard Stallman <rms@gnu.org> writes:

>   > Seems like it sadly isn't possible, as Jonas says:
>
>   > > Adding to GNU ELPA is not an option because one of the main authors is
>   > > against assigning copyright to the FSF as a matter of principle.
>
> That's a shame.  But how big is per code?
> Would it be feasible to write new code to replace that code?

It's not a of code: gitconfig-mode: 137, gitignore-mode: 61,
gitattributes-mode 232 lines, all including headers.  IMO it
would make sense to re-implement them.

gitignore-mode is completely trivial, basically just font-lock keywords.
gitconfig-mode has more font-lock keywords plus some indentation code,
  which I personally find more annoying than helpful.
gitattributes-mode is more complex, also including support for eldoc and
  some navigation commands.  The good news is that in this case we might
  actually be able to get all the required copyright assignments.

Re: [NonGNU ELPA] New package proposal: git-modes

[Stefan Kangas]

Jonas Bernoulli <jonas@bernoul.li> writes:

>> That's a shame.  But how big is per code?
>> Would it be feasible to write new code to replace that code?
>
> It's not a of code: gitconfig-mode: 137, gitignore-mode: 61,
> gitattributes-mode 232 lines, all including headers.  IMO it
> would make sense to re-implement them.
>
> gitignore-mode is completely trivial, basically just font-lock keywords.

Couldn't .gitignore-mode basically just be replaced with
`conf-unix-mode'?  I have gitignore-mode running locally, but I'm not
sure the syntax highlighting it does have is very helpful.  Why
highlight "/" in "foo/bar", for example?

This would be a trivial addition to auto-mode-alist in emacs-28, if
that's something we want to do.

> gitconfig-mode has more font-lock keywords plus some indentation code,
>   which I personally find more annoying than helpful.

By default, we use `conf-mode' for these files, which already looks
pretty good to my eyes.  Is gitconfig-mode much better?

> gitattributes-mode is more complex, also including support for eldoc and
>   some navigation commands.  The good news is that in this case we might
>   actually be able to get all the required copyright assignments.

That's good news, indeed.

Re: [NonGNU ELPA] New package proposal: git-modes

[Juri Linkov]

>> gitignore-mode is completely trivial, basically just font-lock keywords.
>
> Couldn't .gitignore-mode basically just be replaced with
> `conf-unix-mode'?  I have gitignore-mode running locally, but I'm not
> sure the syntax highlighting it does have is very helpful.  Why
> highlight "/" in "foo/bar", for example?

.gitignore is already font-locked after (require 'generic-x),
but specific gitignore-mode is still needed to fontify at least
important syntax of the negation character "!".
But why not add this to generic-x.el?

Re: [NonGNU ELPA] New package proposal: git-modes

[Stefan Kangas]

Juri Linkov <juri@linkov.net> writes:

> .gitignore is already font-locked after (require 'generic-x),
> but specific gitignore-mode is still needed to fontify at least
> important syntax of the negation character "!".
> But why not add this to generic-x.el?

Could we autoload it if we add it there?

Re: [NonGNU ELPA] New package proposal: git-modes

[Juri Linkov]

>> .gitignore is already font-locked after (require 'generic-x),
>> but specific gitignore-mode is still needed to fontify at least
>> important syntax of the negation character "!".
>> But why not add this to generic-x.el?
>
> Could we autoload it if we add it there?

gitignore-mode will autoload the whole generic-x.el with all other modes.
I don't know how to autoload only one mode selectively on demand,
without customizing generic-extras-enable-list.

Re: [NonGNU ELPA] New package proposal: git-modes

[Jonas Bernoulli]

> I have gitignore-mode running locally, but I'm not sure the syntax
> highlighting it does have is very helpful.

I don't really have an opinion on the matter.  I am not the original
author and for the most part just fixed bugs.  Some of the additional
font-lock sugar seems unnecessary to me too.

(If I remember correctly the only reason I agreed to become the
maintainer of these modes is that it was part of the deal that allowed
me to integrate various git-commit.el implementations into the one in
magit.  And that in turn I only wanted to do because the most popular
implementation injected bugs into magit via monkey patches and while its
author refused to stop doing that he offered to completely handover the
package (plus git{config,ignore}.el) to me.)