unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: tumashu <tumashu@163.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: Subject: [PATCH] * lisp/xwidget.el (xwidget-webkit-browse-url): Remove space prefix of url.
Date: Thu, 11 Nov 2021 18:53:19 +0800	[thread overview]
Message-ID: <87wnlfufog.fsf@yahoo.com> (raw)
In-Reply-To: <5708f4fa.3b96.17d0e9d7e34.Coremail.tumashu@163.com> (tumashu@163.com's message of "Thu, 11 Nov 2021 18:49:02 +0800 (CST)")

tumashu <tumashu@163.com> writes:

> I often encountered in this case, when copy url, space begin url hard
> notice :)

I don't think a function intended for use as `browse-url-function'
should make those decisions.  And in any case, one should check a URL
before opening it.

On an unrelated note, I think the use of a regexp for stripping
whitespace is unwarranted.  Wouldn't `url-strip-leading-spaces' be a
better candidate for this job?

Thanks.



  reply	other threads:[~2021-11-11 10:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  9:36 Subject: [PATCH] * lisp/xwidget.el (xwidget-webkit-browse-url): Remove space prefix of url tumashu
2021-11-11  9:39 ` Po Lu
2021-11-11 10:49   ` tumashu
2021-11-11 10:53     ` Po Lu [this message]
2021-11-11 10:53   ` Lars Ingebrigtsen
2021-11-11 11:15     ` Po Lu
2021-11-11 11:58       ` Lars Ingebrigtsen
2021-11-11 12:21         ` Po Lu
2021-11-11 12:25           ` Lars Ingebrigtsen
2021-11-13  1:08             ` Po Lu
2021-11-13  7:45               ` Eli Zaretskii
2021-11-13  9:34                 ` Po Lu
2021-11-13 10:26                   ` Eli Zaretskii
2021-11-13 10:45                     ` Po Lu
2021-11-13 13:29                       ` Eli Zaretskii
2021-11-13 15:32                         ` Stephen Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnlfufog.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=tumashu@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).