unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Po Lu <luangruo@yahoo.com>,
	tumashu@163.com, larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: Subject: [PATCH] * lisp/xwidget.el (xwidget-webkit-browse-url): Remove space prefix of url.
Date: Sat, 13 Nov 2021 16:32:23 +0100	[thread overview]
Message-ID: <874k8gnkag.fsf@rub.de> (raw)
In-Reply-To: <83lf1sxjyh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Nov 2021 15:29:26 +0200")

On Sat, 13 Nov 2021 15:29:26 +0200 Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: tumashu@163.com,  larsi@gnus.org,  emacs-devel@gnu.org
>> Date: Sat, 13 Nov 2021 18:45:26 +0800
>>
>> >   Optional arg LOCAL-REGEX, if non-nil, means don't treat URLs that
>> >   match the regex as queries even if they otherwise look like it."
>>
>> I think "one" would make more sense here, thanks.
>
> "Queries" is plural, so "one" doesn't match.

I think it's grammatically and stylistically fine to repeat "queries"
(instead of using "it" or "one"), but it's also fine to simply drop
"even if they otherwise look like it", since that phrase just emphasizes
the intent without qualifying it.

Steve Berman



      reply	other threads:[~2021-11-13 15:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  9:36 Subject: [PATCH] * lisp/xwidget.el (xwidget-webkit-browse-url): Remove space prefix of url tumashu
2021-11-11  9:39 ` Po Lu
2021-11-11 10:49   ` tumashu
2021-11-11 10:53     ` Po Lu
2021-11-11 10:53   ` Lars Ingebrigtsen
2021-11-11 11:15     ` Po Lu
2021-11-11 11:58       ` Lars Ingebrigtsen
2021-11-11 12:21         ` Po Lu
2021-11-11 12:25           ` Lars Ingebrigtsen
2021-11-13  1:08             ` Po Lu
2021-11-13  7:45               ` Eli Zaretskii
2021-11-13  9:34                 ` Po Lu
2021-11-13 10:26                   ` Eli Zaretskii
2021-11-13 10:45                     ` Po Lu
2021-11-13 13:29                       ` Eli Zaretskii
2021-11-13 15:32                         ` Stephen Berman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k8gnkag.fsf@rub.de \
    --to=stephen.berman@gmx.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    --cc=tumashu@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).