* Master branch build failure on macOS 10.11
[not found] <1494435167.18.1652254777799@porkrind.org>
@ 2022-05-11 19:49 ` David Caldwell
2022-05-12 0:03 ` Po Lu
0 siblings, 1 reply; 6+ messages in thread
From: David Caldwell @ 2022-05-11 19:49 UTC (permalink / raw)
To: emacs
Hi, I'm getting the following errors when trying to build the master
branch on Mac OS 10.11:
> nsterm.m:6248:22: error: use of undeclared identifier 'NSButtonTypeMomentaryPushIn'
> [ok setButtonType: NSButtonTypeMomentaryPushIn];
> ^
> nsterm.m:6253:26: error: use of undeclared identifier 'NSButtonTypeMomentaryPushIn'
> [cancel setButtonType: NSButtonTypeMomentaryPushIn];
> ^
Most likely related to commit 75c26e417474ba9b8d366b28a95ff774cb12f0e5
Is this old version of macOS still supported? Or should I ratchet my
build machine up an OS release?
-David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Master branch build failure on macOS 10.11
2022-05-11 19:49 ` Master branch build failure on macOS 10.11 David Caldwell
@ 2022-05-12 0:03 ` Po Lu
2022-05-12 4:06 ` David Caldwell
0 siblings, 1 reply; 6+ messages in thread
From: Po Lu @ 2022-05-12 0:03 UTC (permalink / raw)
To: David Caldwell; +Cc: emacs
David Caldwell <david@porkrind.org> writes:
> Most likely related to commit 75c26e417474ba9b8d366b28a95ff774cb12f0e5
>
> Is this old version of macOS still supported? Or should I ratchet my
> build machine up an OS release?
We support Mac OS X 10.6 and up, so yes, it is still supported.
Could you find the names of those two constants on older versions of
macOS? Apple does a lot of renaming, and this error might as well be
one of those.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Master branch build failure on macOS 10.11
2022-05-12 0:03 ` Po Lu
@ 2022-05-12 4:06 ` David Caldwell
2022-05-12 4:37 ` Po Lu
0 siblings, 1 reply; 6+ messages in thread
From: David Caldwell @ 2022-05-12 4:06 UTC (permalink / raw)
To: Po Lu; +Cc: emacs
On 5/11/22 5:03 PM, Po Lu wrote:
> David Caldwell <david@porkrind.org> writes:
>
>> Most likely related to commit 75c26e417474ba9b8d366b28a95ff774cb12f0e5
>>
>> Is this old version of macOS still supported? Or should I ratchet my
>> build machine up an OS release?
>
> We support Mac OS X 10.6 and up, so yes, it is still supported.
>
> Could you find the names of those two constants on older versions of
> macOS? Apple does a lot of renaming, and this error might as well be
> one of those.
Sure! My 11.6 sdk says:
> NSButtonTypeMomentaryPushIn = 7,
and on the 10.11 vm I see:
> NSMomentaryPushInButton = 7, // was NSMomentaryLight
Looks like the old one had Button as a suffix instead of a prefix.
-David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Master branch build failure on macOS 10.11
2022-05-12 4:06 ` David Caldwell
@ 2022-05-12 4:37 ` Po Lu
2022-05-12 8:56 ` David Caldwell
0 siblings, 1 reply; 6+ messages in thread
From: Po Lu @ 2022-05-12 4:37 UTC (permalink / raw)
To: David Caldwell; +Cc: emacs
David Caldwell <david@porkrind.org> writes:
> Sure! My 11.6 sdk says:
>
>> NSButtonTypeMomentaryPushIn = 7,
>
> and on the 10.11 vm I see:
>
>> NSMomentaryPushInButton = 7, // was NSMomentaryLight
>
> Looks like the old one had Button as a suffix instead of a prefix.
Does this fix the problem?
diff --git a/src/nsterm.h b/src/nsterm.h
index 9d8a6f486f..ce2355e6b1 100644
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -1329,5 +1329,6 @@ #define NSPasteboardTypeTIFF NSTIFFPboardType
#define NSControlStateValueOn NSOnState
#define NSControlStateValueOff NSOffState
#define NSBezelStyleRounded NSRoundedBezelStyle
+#define NSButtonTypeMomentaryPushIn NSMomentaryPushInButton
#endif
#endif /* HAVE_NS */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Master branch build failure on macOS 10.11
2022-05-12 4:37 ` Po Lu
@ 2022-05-12 8:56 ` David Caldwell
2022-05-12 9:22 ` Po Lu
0 siblings, 1 reply; 6+ messages in thread
From: David Caldwell @ 2022-05-12 8:56 UTC (permalink / raw)
To: Po Lu; +Cc: emacs
On 5/11/22 9:37 PM, Po Lu wrote:
> Does this fix the problem?
>
> diff --git a/src/nsterm.h b/src/nsterm.h
> index 9d8a6f486f..ce2355e6b1 100644
> --- a/src/nsterm.h
> +++ b/src/nsterm.h
> @@ -1329,5 +1329,6 @@ #define NSPasteboardTypeTIFF NSTIFFPboardType
> #define NSControlStateValueOn NSOnState
> #define NSControlStateValueOff NSOffState
> #define NSBezelStyleRounded NSRoundedBezelStyle
> +#define NSButtonTypeMomentaryPushIn NSMomentaryPushInButton
> #endif
> #endif /* HAVE_NS */
Yes, that let it successfully compile. Thanks!
-David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Master branch build failure on macOS 10.11
2022-05-12 8:56 ` David Caldwell
@ 2022-05-12 9:22 ` Po Lu
0 siblings, 0 replies; 6+ messages in thread
From: Po Lu @ 2022-05-12 9:22 UTC (permalink / raw)
To: David Caldwell; +Cc: emacs
David Caldwell <david@porkrind.org> writes:
> Yes, that let it successfully compile. Thanks!
Installed, thanks for testing.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-12 9:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1494435167.18.1652254777799@porkrind.org>
2022-05-11 19:49 ` Master branch build failure on macOS 10.11 David Caldwell
2022-05-12 0:03 ` Po Lu
2022-05-12 4:06 ` David Caldwell
2022-05-12 4:37 ` Po Lu
2022-05-12 8:56 ` David Caldwell
2022-05-12 9:22 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).