Re: Several problems

[Nicolas Avrutin <nicolasavru@gmail.com>]

Your patch fails to compile for me:
frame.c: In function ‘make_initial_frame’:
frame.c:863:40: error: lvalue required as left operand of assignment
   FRAME_HAS_HORIZONTAL_SCROLL_BARS (f) = false;
                                        ^
frame.c: In function ‘make_terminal_frame’:
frame.c:916:40: error: lvalue required as left operand of assignment
   FRAME_HAS_HORIZONTAL_SCROLL_BARS (f) = false;
                                        ^


With your patch, FRAME_HAS_HORIZONTAL_SCROLL_BARS(f) is defined to be
false (the else branch, frame.h:858), resulting in the lines in frame.c
macro expanding to false = false;. As a workaround, I attempted the
following:
diff --git a/src/frame.c b/src/frame.c
index 457024f..ea96fce 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -860,7 +860,11 @@ make_initial_frame (void)
 
 #ifdef HAVE_WINDOW_SYSTEM
   f->vertical_scroll_bar_type = vertical_scroll_bar_none;
+  #if defined (USE_X_TOOLKIT)                                          \
+  || (defined (USE_GTK) && defined (USE_TOOLKIT_SCROLL_BARS))          \
+  || defined (HAVE_NTGUI)
   FRAME_HAS_HORIZONTAL_SCROLL_BARS (f) = false;
+  #endif
 #endif
 
   /* The default value of menu-bar-mode is t.  */
@@ -913,7 +917,11 @@ make_terminal_frame (struct terminal *terminal)
 
 #ifdef HAVE_WINDOW_SYSTEM
   f->vertical_scroll_bar_type = vertical_scroll_bar_none;
+  #if defined (USE_X_TOOLKIT)                                          \
+  || (defined (USE_GTK) && defined (USE_TOOLKIT_SCROLL_BARS))          \
+  || defined (HAVE_NTGUI)
   FRAME_HAS_HORIZONTAL_SCROLL_BARS (f) = false;
+  #endif
 #endif


This allows it to successfully compile, but the crash still occurs.

Thanks
-- 
Nicolas Avrutin