From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Avrutin Newsgroups: gmane.emacs.devel Subject: Re: Several problems Date: Sat, 02 Aug 2014 00:10:08 -0400 Message-ID: <87vbqbldz7.fsf@gateway.local.navru.net> References: <87d2cpbua7.fsf@fencepost.gnu.org> <53D642D8.4050502@gmx.at> <87fvhg1pxi.fsf@gateway.local.navru.net> <53DB90EB.9030808@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1406953229 4497 80.91.229.3 (2 Aug 2014 04:20:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Aug 2014 04:20:29 +0000 (UTC) Cc: David Kastrup , Faried Nawaz , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 02 06:20:22 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XDQns-0005L1-53 for ged-emacs-devel@m.gmane.org; Sat, 02 Aug 2014 06:20:20 +0200 Original-Received: from localhost ([::1]:42930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDQnr-0000MP-FS for ged-emacs-devel@m.gmane.org; Sat, 02 Aug 2014 00:20:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDQno-0000MK-4Z for emacs-devel@gnu.org; Sat, 02 Aug 2014 00:20:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDQnn-0000tZ-AS for emacs-devel@gnu.org; Sat, 02 Aug 2014 00:20:16 -0400 Original-Received: from mail-qa0-x22a.google.com ([2607:f8b0:400d:c00::22a]:40015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDQnl-0000tJ-Ve; Sat, 02 Aug 2014 00:20:14 -0400 Original-Received: by mail-qa0-f42.google.com with SMTP id j15so4839765qaq.15 for ; Fri, 01 Aug 2014 21:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:date:in-reply-to:message-id :mime-version:content-type:content-transfer-encoding; bh=SP6Qna+xi+z/1rCfHcbtIERLfBFP1je/7F2KyJC6YgY=; b=cvqk4EAX4P69z/l1c780ivAhKmClAPYqbZ/+lK80QOaQh1y4eNgnNe09c2i2yGr8BR s8+jjjT25n5+vSskvNw+DygsTgxSyRCBbuFYxTraqViX5kcg1CBXFrVZbMaoVnQMrbyo n3sf27T+Xp6HEn75AQVv5DI/1WXcXpQTgqiPqAZ2on8nzNgWcOVgE1ABLK8W3ZOHWvsH UR6K5AIuuh1GNZf/5c5TY5IQ+sGAiw8ErnNVTGIdYaPJmekh1AfhGgSJQon5lgcHSXEa +gcuWSfHfZD0Smqlb7Mls96f0R6LsstIvat4KG1Jv/R8OrhA/3UD3SjbemCIguZmZWUB CUbg== X-Received: by 10.224.172.129 with SMTP id l1mr15916184qaz.90.1406953213460; Fri, 01 Aug 2014 21:20:13 -0700 (PDT) Original-Received: from gateway.local.navru.net ([2001:470:1f07:7d5::109]) by mx.google.com with ESMTPSA id h5sm11559612qgf.19.2014.08.01.21.20.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Aug 2014 21:20:12 -0700 (PDT) In-reply-to: <53DB90EB.9030808@gmx.at> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c00::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173360 Archived-At: Your patch fails to compile for me: frame.c: In function ‘make_initial_frame’: frame.c:863:40: error: lvalue required as left operand of assignment FRAME_HAS_HORIZONTAL_SCROLL_BARS (f) = false; ^ frame.c: In function ‘make_terminal_frame’: frame.c:916:40: error: lvalue required as left operand of assignment FRAME_HAS_HORIZONTAL_SCROLL_BARS (f) = false; ^ With your patch, FRAME_HAS_HORIZONTAL_SCROLL_BARS(f) is defined to be false (the else branch, frame.h:858), resulting in the lines in frame.c macro expanding to false = false;. As a workaround, I attempted the following: diff --git a/src/frame.c b/src/frame.c index 457024f..ea96fce 100644 --- a/src/frame.c +++ b/src/frame.c @@ -860,7 +860,11 @@ make_initial_frame (void) #ifdef HAVE_WINDOW_SYSTEM f->vertical_scroll_bar_type = vertical_scroll_bar_none; + #if defined (USE_X_TOOLKIT) \ + || (defined (USE_GTK) && defined (USE_TOOLKIT_SCROLL_BARS)) \ + || defined (HAVE_NTGUI) FRAME_HAS_HORIZONTAL_SCROLL_BARS (f) = false; + #endif #endif /* The default value of menu-bar-mode is t. */ @@ -913,7 +917,11 @@ make_terminal_frame (struct terminal *terminal) #ifdef HAVE_WINDOW_SYSTEM f->vertical_scroll_bar_type = vertical_scroll_bar_none; + #if defined (USE_X_TOOLKIT) \ + || (defined (USE_GTK) && defined (USE_TOOLKIT_SCROLL_BARS)) \ + || defined (HAVE_NTGUI) FRAME_HAS_HORIZONTAL_SCROLL_BARS (f) = false; + #endif #endif This allows it to successfully compile, but the crash still occurs. Thanks -- Nicolas Avrutin