[david.ponce@wanadoo.fr: Re: Issues with Windows gcc -mno-cygwin (Mingw)]

[david.ponce@wanadoo.fr: Re: Issues with Windows gcc -mno-cygwin (Mingw)]

[Richard Stallman]

For people's information:

From: David PONCE <david.ponce@wanadoo.fr>
Reply-To: david.ponce@wanadoo.fr
To: rms <rms@gnu.org>
Subject: Re: Issues with Windows gcc -mno-cygwin (Mingw)
Date: Thu, 15 May 2003 09:44:08 +0200 (CEST)
X-Spam-Status: No, hits=-4.4 required=5.0
	tests=PATCH_CONTEXT_DIFF,QUOTED_EMAIL_TEXT,RCVD_IN_MULTIHOP_DSBL,
	      RCVD_IN_UNCONFIRMED_DSBL,SPAM_PHRASE_01_02,
	      TO_LOCALPART_EQ_REAL
	version=2.41
X-Spam-Level: 

Richard Stallman wrote:
>     Would it be possible to commit this patch from Benjamin Riefenstahl:
> 
> When you want us to look at a patch, please include the actual
> patch in your message, not just a reference.
> 

Sorry.  Here is the patch:

Index: emacs.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/emacs.c,v
retrieving revision 1.325
diff -c -p -r1.325 emacs.c
*** emacs.c	18 Dec 2002 06:16:28 -0000	1.325
--- emacs.c	20 Mar 2003 16:17:36 -0000
*************** Boston, MA 02111-1307, USA.  */
*** 40,45 ****
--- 40,49 ----
  #include <sys/ioctl.h>
  #endif
  
+ #ifdef WINDOWSNT
+ #include <fcntl.h>
+ #endif
+ 
  #include "lisp.h"
  #include "commands.h"
  #include "intervals.h"
*************** main (argc, argv
*** 954,964 ****
    uninterrupt_malloc ();
  #endif	/* not SYSTEM_MALLOC */
  
! #ifdef MSDOS
    /* We do all file input/output as binary files.  When we need to translate
       newlines, we do that manually.  */
    _fmode = O_BINARY;
  
  #if __DJGPP__ >= 2
    if (!isatty (fileno (stdin)))
      setmode (fileno (stdin), O_BINARY);
--- 958,970 ----
    uninterrupt_malloc ();
  #endif	/* not SYSTEM_MALLOC */
  
! #if defined (MSDOS) || defined (WINDOWSNT)
    /* We do all file input/output as binary files.  When we need to translate
       newlines, we do that manually.  */
    _fmode = O_BINARY;
+ #endif /* MSDOS || WINDOWSNT */
  
+ #ifdef MSDOS
  #if __DJGPP__ >= 2
    if (!isatty (fileno (stdin)))
      setmode (fileno (stdin), O_BINARY);
Index: unexw32.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/unexw32.c,v
retrieving revision 1.22
diff -c -p -r1.22 unexw32.c
*** unexw32.c	4 Feb 2003 14:03:13 -0000	1.22
--- unexw32.c	20 Mar 2003 16:17:50 -0000
*************** Boston, MA 02111-1307, USA.
*** 23,29 ****
  
  #include <config.h>
  
- #include <stdlib.h> 	/* _fmode */
  #include <stdio.h>
  #include <fcntl.h>
  #include <time.h>
--- 23,28 ----
*************** _start (void)
*** 111,120 ****
  
    /* Grab our malloc arena space now, before CRT starts up. */
    init_heap ();
- 
-   /* The default behavior is to treat files as binary and patch up
-      text files appropriately, in accordance with the MSDOS code.  */
-   _fmode = O_BINARY;
  
    /* This prevents ctrl-c's in shells running while we're suspended from
       having us exit.  */
--- 110,115 ----

Re: [david.ponce@wanadoo.fr: Re: Issues with Windows gcc -mno-cygwin (Mingw)]

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Date: Thu, 15 May 2003 23:51:04 -0400
> 
> For people's information:

This patch is okay with me, assuming that it doesn't break the other
Windows builds (the one with MSVC), something I cannot change.

Re: [david.ponce@wanadoo.fr: Re: Issues with Windows gcc -mno-cygwin (Mingw)]

[Eli Zaretskii]

> Date: Fri, 16 May 2003 15:07:11 +0300
> From: "Eli Zaretskii" <eliz@elta.co.il>
> 
> This patch is okay with me, assuming that it doesn't break the other
> Windows builds (the one with MSVC), something I cannot change.
                                                  ^^^^^^^^^^^^^
This should have been "cannot check", of course.

Re: [david.ponce@wanadoo.fr: Re: Issues with Windows gcc -mno-cygwin (Mingw)]

[Kevin Ryde]

David PONCE <david.ponce@wanadoo.fr> writes:
>
> + #ifdef WINDOWSNT
> + #include <fcntl.h>
> + #endif

Just a nitpick, but probably should use HAVE_FCNTL_H here.