unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Elliott Shugerman <eeshugerman@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Landing feature/more-fds for Emacs 30?
Date: Tue, 14 Mar 2023 18:08:25 +0100	[thread overview]
Message-ID: <87ttynuupi.fsf@gmail.com> (raw)
In-Reply-To: <CAEb3WWaG6MNE++-5DGzD1qPgWqxoVwSRE_UeLWFhKSdijpXZNw@mail.gmail.com> (Elliott Shugerman's message of "Tue, 14 Mar 2023 12:09:37 -0400")

>>>>> On Tue, 14 Mar 2023 12:09:37 -0400, Elliott Shugerman <eeshugerman@gmail.com> said:

    Elliott> Hi,
    Elliott> (Context:
    Elliott> https://lists.gnu.org/archive/html/emacs-devel/2022-05/msg00115.html)

    Elliott> I've been running this patch (rebased on emacs-29) on macOS ever since we added
    Elliott> it to homebrew-emacs-plus
    Elliott> <https://github.com/d12frosted/homebrew-emacs-plus/pull/510> (off by
    Elliott> default) a few months back. It's made a huge difference for me!

    Elliott> I work on a large codebase with LSP and used to run into the "too many open
    Elliott> files" error all the time unless I disabled desired functionality or gave
    Elliott> up native-comp. Now, with this patch, not only is that issue gone entirely,
    Elliott> but I find Emacs is generally more responsive and stable on macOS.

Thatʼs good to know. Iʼve not had a great deal of feedback on it.

    Elliott> More recently I installed this patch on my GNU/Linux box as well and have
    Elliott> noticed no differences at all there (which is good/expected because I've
    Elliott> only ever run into such issues on macOS, in part because I make heavier use
    Elliott> of it these days (reluctantly), but also due to technical differences IIUC).

The issue tends to happen when you have file notification turned on,
and the Linux kernel implementation of that scales better than the
macOS one (unless we switch to the new macOS notification api, but we
already have 3 different ones...)

    Elliott> Anyway, that's all to say, thanks for this patch! And... can it be merged
    Elliott> now that emacs-29 is cut? :)

Not as is. There are a number of other parts of Emacs that need
adapting to the possibility if having >1024 open filedescriptors. I
have most of that done, but as usual Real Life™ interferes.

Iʼll see if I can schedule some time to finish it off. After all,
Emacs 30 needs some changes that can cause instability in fundamental
code ;-)

Robert
-- 



  reply	other threads:[~2023-03-14 17:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 16:09 Landing feature/more-fds for Emacs 30? Elliott Shugerman
2023-03-14 17:08 ` Robert Pluim [this message]
2023-03-14 19:37   ` Eli Zaretskii
2023-03-15  8:48   ` Michael Albinus
2023-03-15  9:21     ` Robert Pluim
2023-03-15  9:31       ` Michael Albinus
2023-03-15 10:22         ` Robert Pluim
2023-10-03  6:30   ` Stefan Kangas
2023-10-06 10:19     ` Robert Pluim
2023-10-06 11:23       ` Stefan Kangas
2023-10-06 11:52         ` Robert Pluim
2023-10-06 12:13         ` Eli Zaretskii
2023-03-15 17:12 ` João Távora
2023-03-15 17:37   ` Robert Pluim
2023-03-15 18:02     ` João Távora
     [not found]       ` <CAEb3WWaQM8NskPUqX1S2L_ampAZmv+X+8CwKTxc9urD1rhfexg@mail.gmail.com>
     [not found]         ` <CALDnm51kRCevuZN2=nyjkoxKk4XTxySO1c3e9BWNL-Rvz8B7Vw@mail.gmail.com>
2023-03-25 18:52           ` Elliott Shugerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttynuupi.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=eeshugerman@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).