From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Landing feature/more-fds for Emacs 30? Date: Tue, 14 Mar 2023 18:08:25 +0100 Message-ID: <87ttynuupi.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8797"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Elliott Shugerman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 14 18:09:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc89Q-00024T-G2 for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Mar 2023 18:09:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pc88X-00063Y-FW; Tue, 14 Mar 2023 13:08:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pc88V-00063B-KU for emacs-devel@gnu.org; Tue, 14 Mar 2023 13:08:31 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pc88U-000691-0A for emacs-devel@gnu.org; Tue, 14 Mar 2023 13:08:31 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id l12so6752347wrm.10 for ; Tue, 14 Mar 2023 10:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678813708; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=TS9j0CBFHAKLXeYsvPGe2f56IXGj3WRedASUfbAfb9w=; b=FL5o/BdY/TdqHmab0UHZNJcDa0QvLH6P/i2khXFZnbP+FvnCPDczwSpaqIPkJxyfLR w9OOC1BjLUG5ozjMHKqN+2+VWm4xM9P/rpw44fJEnRzFTnw+VJpQePE6v5hhgi/7KN+7 6bYYZCpXAIl/7DjrICQVtaA4z7syFlz9E5564P91PI4D0YJ/ozHQ7uWSjciN2iSQ7nMQ NepSv05IDd0Lq+SrFOUmqPmSh5pwpyEW7JI9bNpyab4nSGjK68uWESFkJwpy0B3sstwo rfLJMUl6PcbDf3lEckkIaPxSXRhE4IbSB5rntli6mtbQuTP2w3yZBA92SGdjczjbaZtE lBNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678813708; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TS9j0CBFHAKLXeYsvPGe2f56IXGj3WRedASUfbAfb9w=; b=cVoaqAZaa4OIlJG9vnPjDa7D/S0q2lAkJnJNDaONqDfVhdzc3EC2vX+RTS0OWoDHD0 VbyzlgoUKEgv7tFlKAZxnBdO+BJCeTUbvC3Y3Iq2xwREjJecOJqFAs5QbTpQvAOPWIGm RphZpytN05cAODOVYmwdhOcGq8j3c6YW77cxh0iLJQ6CouTp6YAr8mduN0BN4yk5NKmi PU+8j7YzgP2EBtq6iYXXcNI3XG8yo2Fm/4OkSncQx0OOpyV4xrFxatXpxdGjv+IA9ZGk vP1WGmeAuL7sov9rvo/Pp+xrO2LEVr6p0BE4oK5V5+wdfL3gVejE9H5yOBISwOHbGOyO X3WA== X-Gm-Message-State: AO0yUKUtc5KnEi/XRZFdeqdTrmsq8x7khJCMTN181wrV1veHIWrVgzO5 G5iZ/jitmoxz7416Gfsj/ONkb58IdFw= X-Google-Smtp-Source: AK7set918MPVw3U/6yDzxcagBx5lIcggbFZX/PNXjsfcIHlZUPD5fNkHAPBIPsYAwlOSADihLcpT5Q== X-Received: by 2002:a05:6000:1809:b0:2c7:f82:827a with SMTP id m9-20020a056000180900b002c70f82827amr24235331wrh.19.1678813708139; Tue, 14 Mar 2023 10:08:28 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id i7-20020a5d6307000000b002c70851bfcasm2557709wru.28.2023.03.14.10.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 10:08:27 -0700 (PDT) In-Reply-To: (Elliott Shugerman's message of "Tue, 14 Mar 2023 12:09:37 -0400") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304454 Archived-At: >>>>> On Tue, 14 Mar 2023 12:09:37 -0400, Elliott Shugerman said: Elliott> Hi, Elliott> (Context: Elliott> https://lists.gnu.org/archive/html/emacs-devel/2022-05/msg0011= 5.html) Elliott> I've been running this patch (rebased on emacs-29) on macOS ev= er since we added Elliott> it to homebrew-emacs-plus Elliott> (= off by Elliott> default) a few months back. It's made a huge difference for me! Elliott> I work on a large codebase with LSP and used to run into the "= too many open Elliott> files" error all the time unless I disabled desired functional= ity or gave Elliott> up native-comp. Now, with this patch, not only is that issue g= one entirely, Elliott> but I find Emacs is generally more responsive and stable on ma= cOS. That=CA=BCs good to know. I=CA=BCve not had a great deal of feedback on it. Elliott> More recently I installed this patch on my GNU/Linux box as we= ll and have Elliott> noticed no differences at all there (which is good/expected be= cause I've Elliott> only ever run into such issues on macOS, in part because I mak= e heavier use Elliott> of it these days (reluctantly), but also due to technical diff= erences IIUC). The issue tends to happen when you have file notification turned on, and the Linux kernel implementation of that scales better than the macOS one (unless we switch to the new macOS notification api, but we already have 3 different ones...) Elliott> Anyway, that's all to say, thanks for this patch! And... can i= t be merged Elliott> now that emacs-29 is cut? :) Not as is. There are a number of other parts of Emacs that need adapting to the possibility if having >1024 open filedescriptors. I have most of that done, but as usual Real Life=E2=84=A2 interferes. I=CA=BCll see if I can schedule some time to finish it off. After all, Emacs 30 needs some changes that can cause instability in fundamental code ;-) Robert --=20