From: Felician Nemeth <felician.nemeth@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: Stephen Leake <stephen_leake@stephe-leake.org>,
Sebastian Poeplau <sebastian.poeplau@mailbox.org>,
emacs-devel@gnu.org
Subject: Re: eglot's interface for major modes
Date: Thu, 13 Apr 2023 19:43:41 +0200 [thread overview]
Message-ID: <87ttxjhe42.fsf@betli.tmit.bme.hu> (raw)
In-Reply-To: <CALDnm52mmBdJjZHGJmDaYiu9gShnSi=-mNBFTMp30eTjJLzQqg@mail.gmail.com> ("João Távora"'s message of "Thu, 13 Apr 2023 17:22:33 +0100")
João Távora <joaotavora@gmail.com> writes:
>> >> 2. Should the handler for "window/showDocument" be part of eglot?
>>
>> See bug#62116
>
> Speaking of that, that bug seems to have stalled without feedback from
> the OP, who provided a patch. But you also had a patch stashed
> somewhere, which I think we should just revive. It was a simple
> patch, AFAICR.
I can sent my patch with a correct commit log in a couple days. Until
then it is here: https://github.com/joaotavora/eglot/pull/855
> The main reason I haven't been working on this is that I don't
> have any server that invokes window/showDocument that I can
> test. Maybe you do?
Alan Donovan wrote his version for gopls, but he indicated my version is
not enough for gopls.
I tested my version with my own toy server. Since I wrote both the
server and the client side, it is not good for general testing.
Sebastian's version does not fully implement the protocol, but the Ada
Langauge Server might be a good choice to test the implementation
against. In his example, the server sends the window/showDocument
request in reaction to an eglot-execute-command client-request. I don't
know if that complicates a potential testing process. Probably not.
Felicián
next prev parent reply other threads:[~2023-04-13 17:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 18:20 eglot's interface for major modes Sebastian Poeplau
2023-04-07 21:26 ` Stephen Leake
2023-04-08 9:13 ` Felician Nemeth
2023-04-08 9:37 ` Sebastian Poeplau
2023-04-11 14:05 ` Felician Nemeth
2023-04-13 19:24 ` Sebastian Poeplau
2023-04-13 16:22 ` João Távora
2023-04-13 17:43 ` Felician Nemeth [this message]
2023-04-13 19:36 ` Sebastian Poeplau
2023-04-08 9:26 ` Sebastian Poeplau
2023-04-08 10:30 ` Stephen Leake
2023-04-08 10:53 ` Sebastian Poeplau
2023-04-12 23:06 ` Stephen Leake
2023-04-13 19:23 ` Sebastian Poeplau
2023-04-15 16:38 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttxjhe42.fsf@betli.tmit.bme.hu \
--to=felician.nemeth@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=sebastian.poeplau@mailbox.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).