From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.devel Subject: Re: eglot's interface for major modes Date: Thu, 13 Apr 2023 19:43:41 +0200 Message-ID: <87ttxjhe42.fsf@betli.tmit.bme.hu> References: <874jpr35eh.fsf@mailbox.org> <86v8i7tmda.fsf@stephe-leake.org> <87jzymzqh2.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40261"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Stephen Leake , Sebastian Poeplau , emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 13 19:45:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pn10Y-000AJy-3L for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Apr 2023 19:45:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pn0zA-0001Nm-5k; Thu, 13 Apr 2023 13:43:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pn0z6-0001N4-Gb for emacs-devel@gnu.org; Thu, 13 Apr 2023 13:43:48 -0400 Original-Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pn0z4-0006Vu-Ol for emacs-devel@gnu.org; Thu, 13 Apr 2023 13:43:48 -0400 Original-Received: by mail-ej1-x62a.google.com with SMTP id rp27so2384997ejb.12 for ; Thu, 13 Apr 2023 10:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681407823; x=1683999823; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=SSmIXc8flRKdKCAQVf2C8wSZljEeFP5fQK0kfmX7uRc=; b=P7lwmMpmJ+4DXfX98v7naFHBW3J/IyqjF0lxX5ayYR5rTX9lP2Qo2DM7rhIVLnG6KY ZrWiwZc19pQdn5IlpKmMic78GSlA5YwjoG4XpFoZrgkGyZhU1D2oE1557Y5h61Lle0vx 7ZXsRIwZ26UMZdkqx38NN989yUWPNMf++lUv44zrd0gU+vhDax/u19sGW+qlZVE7PnQG 0fUSNMo4zOjY3SlxtatvOSS0RJsA8ZjmV2mjfRUfl+5zWaljXkItjO7CtgCIztBf14+Q b2gmk7qVVSxNVAFR491mkSO4JFQcgzDAn3M7zwbO2d2b9yQ4QvR9xN7W1XCcf2FLUAoB ZdGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681407823; x=1683999823; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SSmIXc8flRKdKCAQVf2C8wSZljEeFP5fQK0kfmX7uRc=; b=eP0XMzaFqIlLXzrwcmKovsLAP4pV2ab5pTLgSjkSXCNVHoCfA11yS5VaPvk/MnXBaE 6/UzYqS5XoyQw5Rf5WhEVLQ3Yj2TddmTWQx+l9QnN6BrUBG8sGADFXggQfSYXIMjgTz/ ORwFWN8Aj7bDJCw0X8AP+f6Z2GTuTaZE5/UAzvachEXEfKPfqnavpipn5t63SKjIBisw nqBA4Yf5Kll+dZXYnA+Je8+bj8fvuifSIgOWeslGZfjk0K0WcuhGMriE0+7+SF+8zEmX 5wqHLkntqs0HUKWMmiMQAaJ7ceqMu942tSsNUnkD4SolqgzLWw/NrfznFV6NYziVhi5t 5Otg== X-Gm-Message-State: AAQBX9cmmwMjggtKSKaj3WNkteUh95BzUm2pGGQcdm+jfzElYBhGUOPn gmFyDoTPnW0NcOM91aBTLrtoJHIgGc8= X-Google-Smtp-Source: AKy350aN9DBW3ziuzDmtaxlUER9nA2Q0ks/UyCqL2Rjy5MUFLdq6Ko9qGUGQbkJCGE0n12H6ymUQBA== X-Received: by 2002:a17:906:8381:b0:94a:5a9e:9da4 with SMTP id p1-20020a170906838100b0094a5a9e9da4mr3500840ejx.43.1681407822730; Thu, 13 Apr 2023 10:43:42 -0700 (PDT) Original-Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id f20-20020a170906739400b0094ecbf906ecsm339063ejl.41.2023.04.13.10.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 10:43:42 -0700 (PDT) In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Thu, 13 Apr 2023 17:22:33 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=felician.nemeth@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305296 Archived-At: Jo=C3=A3o T=C3=A1vora writes: >> >> 2. Should the handler for "window/showDocument" be part of eglot? >> >> See bug#62116 > > Speaking of that, that bug seems to have stalled without feedback from > the OP, who provided a patch. But you also had a patch stashed > somewhere, which I think we should just revive. It was a simple > patch, AFAICR. I can sent my patch with a correct commit log in a couple days. Until then it is here: https://github.com/joaotavora/eglot/pull/855 > The main reason I haven't been working on this is that I don't > have any server that invokes window/showDocument that I can > test. Maybe you do? Alan Donovan wrote his version for gopls, but he indicated my version is not enough for gopls. I tested my version with my own toy server. Since I wrote both the server and the client side, it is not good for general testing. Sebastian's version does not fully implement the protocol, but the Ada Langauge Server might be a good choice to test the implementation against. In his example, the server sends the window/showDocument request in reaction to an eglot-execute-command client-request. I don't know if that complicates a potential testing process. Probably not. Felici=C3=A1n